Failure testing for 4.0 flight certification#15965
Failure testing for 4.0 flight certification#15965amilcarlucas wants to merge 12 commits intoArduPilot:Copter-4.0from
Conversation
There was a problem hiding this comment.
I could not forward port the very last hunk on:
https://github.com/matternet/ardupilot/pull/136/files#diff-5982efe4f3484c5853d9713d7608b7b6d050325d4c204b92952f63031b14066aL66
That hole void AP_RangeFinder_Backend::update_pre_arm_check() function is missing in Copter-4.0 :(
ArduCopter/RC_Channel.cpp
Outdated
There was a problem hiding this comment.
Why aren't the other kill functions also listed here?
There was a problem hiding this comment.
get_primary() is no longer available in Copter-4.0. Any ideas how to fix this?
libraries/RC_Channel/RC_Channel.h
Outdated
There was a problem hiding this comment.
Should I expand this to 8 motors? Anybody interested in that?
There was a problem hiding this comment.
Strictly it should yo up to 12, maybe better to have a bitmask param and single switch. For motors you can do it all with scripting, then we don't have the case where people set this up by mistake.
There was a problem hiding this comment.
perhaps you could reuse one of the plane only rc options so as to avoid burning one up just for testing/certification in Copter only....like 87,88, or 89? but I guess we have a lot in the 100 range
|
This doesn't seem appropriate to go into the 4.0 branch, this seems like it
should go into master instead, then maybe be back ported. (Even then I
wouldn't really support back porting this).
…On Thu, Dec 3, 2020, 11:42 Henry Wurzburg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In libraries/RC_Channel/RC_Channel.h
<#15965 (comment)>:
> @@ -178,6 +178,15 @@ class RC_Channel {
KILL_IMU1 = 100, // disable first IMU (for IMU failure testing)
KILL_IMU2 = 101, // disable second IMU (for IMU failure testing)
CAM_MODE_TOGGLE = 102, // Momentary switch to cycle camera modes
+ KILL_ALL = 103, // kill all motors
+ KILL_MOT1 = 104, // kill motor 1
+ KILL_MOT2 = 105, // kill motor 2
+ KILL_MOT3 = 106, // kill motor 3
+ KILL_MOT4 = 107, // kill motor 4
perhaps you could reuse one of the plane only rc options so as to avoid
burning one up just for testing/certification....like 87,88, or 89?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15965 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKTCHRABACK2OKRYCOWR3SS7EZXANCNFSM4ULZZMOA>
.
|
|
@WickedShell This is not meant to be merged. This is meant to be a PR for developers only. |
|
I don't understand why it's targeted at 4.0 then, or why it's a open PR.
I'm not sure we need more PR's in the list of it's never going to get
merged...
…On Fri, Dec 4, 2020, 03:12 Amilcar Lucas ***@***.***> wrote:
@WickedShell <https://github.com/WickedShell> This is not meant to be
merged. This is meant to be a for developers only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15965 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKTCHSVOID3OUWZLDDTT3STCRYXANCNFSM4ULZZMOA>
.
|
amilcarlucas
force-pushed
the
pr-failure-testing-for-4.0-certification
branch
from
7d20829 to
e527e91
Compare
|
@WickedShell |
amilcarlucas
force-pushed
the
pr-failure-testing-for-4.0-certification
branch
from
e527e91 to
1faa138
Compare
…ting. DO NOT use this in production code. Meant for flight certification tests and code development purposes only
…e testing. DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
DO NOT use this in production code. Meant for flight certification tests and code development purposes only
Does only work for Ublox GNSS. DO NOT use this in production code. Meant for flight certification tests and code development purposes only
amilcarlucas
force-pushed
the
pr-failure-testing-for-4.0-certification
branch
from
1faa138 to
517d10a
Compare
|
Added to 4.0 back-port projects and closing. Otherwise this will it open for ever. |
5 participants
This is a forward port of matternet/ardupilot#136 from Copter-3.5.7 to to the Copter-4.0 branch.
I also improved the commit messages a bit.
This is meant for testing purposes only. This enables some flight certification tests.
DO NOT use in production