Skip to content

[Fix] 한국어 루틴 생성 시 농구 용어 번역 품질 개선 #81

Merged
zweadfx merged 2 commits intomainfrom
fix/ko-drill-terminology
Apr 6, 2026
Merged

[Fix] 한국어 루틴 생성 시 농구 용어 번역 품질 개선 #81
zweadfx merged 2 commits intomainfrom
fix/ko-drill-terminology

Conversation

@zweadfx
Copy link
Copy Markdown
Owner

@zweadfx zweadfx commented Apr 6, 2026

어떤 변경사항인가요?

한국어 루틴 생성 시 "비우수 드리블", "피겨 8드리블" 등 부자연스러운 농구 용어 번역 문제를 해결합니다.
드릴 데이터에 한국어 이름을 추가하고, 프롬프트에 용어 번역 가이드라인을 적용합니다.

작업 상세 내용

  • 드릴 데이터(data/raw/drills.json)에 name_ko 필드 추가 (47개 드릴)
  • ChromaDB 메타데이터에 name_ko 저장하도록 수정
  • 한국어 요청 시 RAG 컨텍스트에서 name_ko를 우선 사용하도록 수정 (coach, weekly_coach, refine 에이전트 4개)
  • 생성 프롬프트에 한국어 농구 용어 번역 가이드라인 추가
  • .gitignore*.db, .idea/ 추적 해제

체크리스트

  • self-test를 수행하였는가?
  • 관련 문서나 주석을 업데이트하였는가?
  • 설정한 코딩 컨벤션을 준수하였는가?

관련 이슈

리뷰 포인트

  • name_ko 번역이 한국 농구에서 실제로 통용되는 표현인지 확인
  • 기존 ChromaDB 컬렉션은 name_ko 없이 저장되어 있으므로, drills 컬렉션 재초기화 필요 (서버 재시작 시 자동 처리)
  • 프롬프트 용어 가이드라인이 한국어(ko) 요청에만 조건부 삽입됨 — 영어 요청에는 영향 없음

참고사항 및 스크린샷(선택)

개선 전: "비우수 드리블", "피겨 8드리블", "엘보 슛"
개선 후: "크로스오버 드리블", "8자 드리블", "스텝백 3점슛" 등 자연스러운 표현

Summary by CodeRabbit

  • New Features

    • Added Korean language support for drill names and coaching instructions; content now displays in Korean based on user language preference.
  • Chores

    • Removed IDE configuration files from version control.
    • Updated database handling to exclude SQLite files from repository.

@zweadfx zweadfx linked an issue Apr 6, 2026 that may be closed by this pull request
3 tasks
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 51915b18-22ac-4e3f-a36d-1941386b037b

📥 Commits

Reviewing files that changed from the base of the PR and between c661a58 and 5877527.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (13)
  • .gitignore
  • .idea/.gitignore
  • .idea/assist.iml
  • .idea/inspectionProfiles/profiles_settings.xml
  • .idea/misc.xml
  • .idea/modules.xml
  • .idea/vcs.xml
  • data/raw/drills.json
  • src/services/agents/coach_agent.py
  • src/services/agents/coach_refine_agent.py
  • src/services/agents/weekly_coach_agent.py
  • src/services/agents/weekly_coach_refine_agent.py
  • src/services/rag/chroma_db.py
💤 Files with no reviewable changes (6)
  • .idea/assist.iml
  • .idea/misc.xml
  • .idea/vcs.xml
  • .idea/.gitignore
  • .idea/inspectionProfiles/profiles_settings.xml
  • .idea/modules.xml

📝 Walkthrough

Walkthrough

This PR introduces Korean language support to the coaching application by adding Korean drill names (name_ko) to the drill dataset, updating RAG prompts to conditionally prefer Korean names when language is set to Korean, and extending LLM prompts with Korean basketball terminology rules. Additionally, IDE configuration files are removed and .gitignore is updated to exclude SQLite database files.

Changes

Cohort / File(s) Summary
IDE Configuration Cleanup
.idea/.gitignore, .idea/assist.iml, .idea/inspectionProfiles/profiles_settings.xml, .idea/misc.xml, .idea/modules.xml, .idea/vcs.xml
Removed JetBrains IDE-specific configuration files and cleared .idea/.gitignore to stop tracking IDE metadata.
Git Configuration
.gitignore
Added SQLite database file pattern (*.db) to exclude .db files from version control.
Drill Data Localization
data/raw/drills.json
Added Korean name field (name_ko) to all drill objects; reformatted required_equipment and tags arrays from inline to multi-line format for readability.
Coach Agent Services
src/services/agents/coach_agent.py, src/services/agents/coach_refine_agent.py, src/services/agents/weekly_coach_agent.py, src/services/agents/weekly_coach_refine_agent.py
Updated drill name selection in LLM prompts to prefer name_ko metadata when language == 'ko'; added conditional Korean basketball terminology rules to prompts when generating Korean-language content.
RAG Metadata Storage
src/services/rag/chroma_db.py
Extended drill metadata schema to include name_ko field when adding drills to ChromaDB collection.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Possibly related PRs

Poem

🐰 Korean drills now hop with pride,
With name_ko fields spread far and wide,
The coach speaks Seoul, the hoops still ring,
농구 용어 guides everything! 🏀
Language flows where code convenes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main purpose of the changeset: improving Korean basketball terminology translation quality during routine generation. It directly reflects the primary changes in the PR.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ko-drill-terminology

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zweadfx zweadfx self-assigned this Apr 6, 2026
@zweadfx zweadfx added the bug 발견된 오류나 결함을 수정할 때 사용합니다. label Apr 6, 2026
@zweadfx zweadfx merged commit f067097 into main Apr 6, 2026
2 checks passed
@zweadfx zweadfx deleted the fix/ko-drill-terminology branch April 6, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 발견된 오류나 결함을 수정할 때 사용합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 한국어 루틴 생성 시 농구 용어 번역 품질 개선

1 participant