[Fix] 한국어 농구 용어 매핑 테이블 확장

[zweadfx]

어떤 변경사항인가요?

한국어 루틴 생성 시 농구 용어 번역 품질을 개선합니다.
기존 인라인 가이드라인을 50+개 용어 매핑 테이블로 확장하고, 4개 에이전트에서 공통 상수로 재사용하도록 통일합니다.

작업 상세 내용

• KO_BASKETBALL_TERMINOLOGY 상수에 50+개 용어 매핑 테이블 추가
• weekly_coach_agent, weekly_coach_refine_agent의 인라인 가이드라인을 공통 상수로 교체

체크리스트

• self-test를 수행하였는가?
• 관련 문서나 주석을 업데이트하였는가?
• 설정한 코딩 컨벤션을 준수하였는가?

관련 이슈

• 관련 이슈: [Fix] 한국어 루틴 생성 시 농구 용어 번역 품질 개선 #80

리뷰 포인트

• 용어 매핑 테이블의 한국어 표현이 실제 통용되는 표현인지 확인
• 4개 에이전트 모두 동일한 KO_BASKETBALL_TERMINOLOGY 상수를 사용하는지 확인

참고사항 및 스크린샷(선택)

개선 전: "프리드로우", "엘보 슛", "피겨-8"
개선 후: "자유투", "엘보 점퍼", "8자 드리블"

Summary by CodeRabbit

• Refactor
  • Centralized Korean basketball terminology and related instructions into a single shared source to ensure consistent Korean wording across the app.
  • User-facing behavior unchanged; Korean responses now use the consolidated terminology, reducing duplication and improving consistency in translated terms and drill names.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 46df4e6a-a94b-4254-8fbb-9edf3fc4d9b9

📥 Commits

Reviewing files that changed from the base of the PR and between bbb8993 and c418845.

📒 Files selected for processing (1)

• src/core/constants.py

🚧 Files skipped from review as they are similar to previous changes (1)

• src/core/constants.py

---

📝 Walkthrough

Walkthrough

Extracted an inline Korean basketball terminology prompt from four agent modules and centralized it as KO_BASKETBALL_TERMINOLOGY in src/core/constants.py; agent files now import and reference this constant, preserving existing conditional behavior.

Changes

Cohort / File(s)	Summary
Korean Terminology Constant src/core/constants.py	Added KO_BASKETBALL_TERMINOLOGY: str containing English→Korean term mappings and Korean-language prompt rules.
Agent Service Updates src/services/agents/coach_agent.py, src/services/agents/coach_refine_agent.py, src/services/agents/weekly_coach_agent.py, src/services/agents/weekly_coach_refine_agent.py	Replaced duplicated inline Korean terminology blocks with an imported KO_BASKETBALL_TERMINOLOGY constant; conditional insertion for language == "ko" remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [Fix] 한국어 루틴 생성 시 농구 용어 번역 품질 개선  #81: Introduced the original inline Korean terminology and name_ko handling in the coach/weekly agent prompts that this change centralizes.

Poem

🐰 I hopped through prompts both near and far,

Collected terms like a bright little star.
Now one tidy constant holds the key—
Korean hoops speak clearly, thanks to me! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: extracting and expanding a Korean basketball terminology mapping table into a shared constant across multiple agents.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ko-terminology-expansion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/services/agents/coach_refine_agent.py (1)

132-133: Missing newline before Instructions section.

Same issue as in weekly_coach_refine_agent.py — the terminology injection runs directly into the next section header.

Suggested fix

 **Language:**
 Respond in {language_name}. All string fields must be in {language_name}.
 {"" if language != "ko" else KO_BASKETBALL_TERMINOLOGY}
+
 **Instructions:**

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/services/agents/coach_refine_agent.py` around lines 132 - 133, The
KO_BASKETBALL_TERMINOLOGY injection is concatenated directly into the next
section header, causing the "**Instructions:**" header to run together; update
the template where KO_BASKETBALL_TERMINOLOGY is inserted (the expression "{"" if
language != "ko" else KO_BASKETBALL_TERMINOLOGY}") so it ensures a newline (or
blank line) after the terminology when language == "ko", e.g., append "\n" or
"\n\n" to KO_BASKETBALL_TERMINOLOGY or alter the surrounding string to insert a
separating newline before the "**Instructions:**" header.

src/services/agents/weekly_coach_refine_agent.py (1)

154-155: Missing newline before Instructions section.

The terminology block will run directly into the **Instructions:** heading without a blank line separator, which may reduce prompt clarity for the LLM.

Suggested fix

 **Language:**
 Respond in {language_name}. All string fields must be in {language_name}.
 {"" if language != "ko" else KO_BASKETBALL_TERMINOLOGY}
+
 **Instructions:**

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/services/agents/weekly_coach_refine_agent.py` around lines 154 - 155, The
prompt concatenation currently emits the KO_BASKETBALL_TERMINOLOGY directly
adjacent to the "**Instructions:**" heading (see use of
KO_BASKETBALL_TERMINOLOGY and language) — insert a blank line separator between
the terminology block and the "**Instructions:**" heading (e.g., ensure the
template or f-string uses "\n\n" after the terminology conditional) so the
heading is on a new line and the prompt is clearer for the LLM.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/core/constants.py`:
- Line 43: Replace the corrupted Korean text in the constants file by locating
the affected string literals/comments containing the garbled fragments and
updating them as follows: change "용어 매핑표··" to "용어 매핑표를", change "전···" to "전환",
and change "한···어" to "한국어"; ensure you update the exact occurrences of those
corrupted substrings so the terminology mapping text is rendered correctly.

---

Nitpick comments:
In `@src/services/agents/coach_refine_agent.py`:
- Around line 132-133: The KO_BASKETBALL_TERMINOLOGY injection is concatenated
directly into the next section header, causing the "**Instructions:**" header to
run together; update the template where KO_BASKETBALL_TERMINOLOGY is inserted
(the expression "{"" if language != "ko" else KO_BASKETBALL_TERMINOLOGY}") so it
ensures a newline (or blank line) after the terminology when language == "ko",
e.g., append "\n" or "\n\n" to KO_BASKETBALL_TERMINOLOGY or alter the
surrounding string to insert a separating newline before the "**Instructions:**"
header.

In `@src/services/agents/weekly_coach_refine_agent.py`:
- Around line 154-155: The prompt concatenation currently emits the
KO_BASKETBALL_TERMINOLOGY directly adjacent to the "**Instructions:**" heading
(see use of KO_BASKETBALL_TERMINOLOGY and language) — insert a blank line
separator between the terminology block and the "**Instructions:**" heading
(e.g., ensure the template or f-string uses "\n\n" after the terminology
conditional) so the heading is on a new line and the prompt is clearer for the
LLM.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 05dd6d45-7cb0-475d-9a9f-1d58c4ee771e

📥 Commits

Reviewing files that changed from the base of the PR and between f067097 and bbb8993.

📒 Files selected for processing (5)

• src/core/constants.py
• src/services/agents/coach_agent.py
• src/services/agents/coach_refine_agent.py
• src/services/agents/weekly_coach_agent.py
• src/services/agents/weekly_coach_refine_agent.py