Skip to content

Comments

feat(rpc): add z_validateaddress endpoint#389

Open
nachog00 wants to merge 59 commits intodevfrom
implement-z_validateaddress
Open

feat(rpc): add z_validateaddress endpoint#389
nachog00 wants to merge 59 commits intodevfrom
implement-z_validateaddress

Conversation

@nachog00
Copy link
Contributor

@nachog00 nachog00 commented Jun 19, 2025

Motivation

#219.

Solution

Implement z_validateaddress.

  • The PR name is suitable for the release notes.
  • The solution is tested.
  • The documentation is up to date.

- Modified response.rs to include a new struct ZValidateAddressResponse

Went for a flattened spec like struct for now, but I dont really like how this results in a bunch of options...
@nachog00 nachog00 self-assigned this Jun 24, 2025
@nachog00
Copy link
Contributor Author

nachog00 commented Jun 24, 2025

This approach is outdated. We are PRing into zebra to have their methods exposed (both for this and validateaddreess).

I'll hold off until ZcashFoundation/zebra#9658 get's reviewed to PR the analogous changes for this RPC in zebra, that way we avoid back and forward with placing of the refactored function. This PR will be redone with that pattern too.

@zancas
Copy link
Member

zancas commented Jun 27, 2025

Is this still planned for Zaino.. or is the functionality going to be elsewhere... let's figure this out and, if correct, close this PR. Or else say why not.

@ala-mode
Copy link
Contributor

ala-mode commented Jul 8, 2025

I'll hold off until ZcashFoundation/zebra#9658 get's reviewed to PR the analogous changes for this RPC in zebra...

Just as a heads up, this got merged into zebra ~5 days ago.

@zancas zancas added the block explorer support This item is needed to support Zcash Block Explorer label Jul 16, 2025
@dorianvp dorianvp changed the title implement z_validateaddress feat(rpc): add z_validateaddress endpoint Oct 19, 2025
@dorianvp dorianvp assigned dorianvp and unassigned nachog00 Oct 19, 2025
@dorianvp dorianvp marked this pull request as ready for review October 23, 2025 02:23
@dorianvp dorianvp requested review from AloeareV, pacu and zancas October 23, 2025 02:23
@zancas
Copy link
Member

zancas commented Nov 5, 2025

One more little thing that seems off.

@fluidvanadium What?

@fluidvanadium
Copy link
Contributor

One more little thing that seems off.

@fluidvanadium What?

That was error handling. Now the only issue is partial sapling keys

pacu
pacu previously approved these changes Nov 5, 2025
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK! (modulo fixing the failing test)

@zancas zancas assigned zancas and unassigned dorianvp Nov 7, 2025
@zancas
Copy link
Member

zancas commented Nov 13, 2025

@nachog00 what's the status of this work. I thought that it was quite close to completion, but now I see merge conflicts.

Can you update it and resolve the conflicts, or close it as won't merge?

fluidvanadium
fluidvanadium previously approved these changes Nov 28, 2025
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluidvanadium fluidvanadium dismissed stale reviews from pacu and themself via 547a5aa November 28, 2025 17:42
@fluidvanadium fluidvanadium self-assigned this Dec 1, 2025
@fluidvanadium fluidvanadium linked an issue Dec 9, 2025 that may be closed by this pull request
@fluidvanadium fluidvanadium mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

block explorer support This item is needed to support Zcash Block Explorer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

z_validate_address tests show divergent behavior 1.23: Add Zcash RPC z_validateaddress

6 participants