Conversation
| # Zingo-infra | ||
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zingo_test_vectors = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", branch = "dev" } |
There was a problem hiding this comment.
Hey we try to keep imports to at least using get revs so that libraries are not updated accidentally.
We actually need to go further than this to support the upcoming crates.io release, for this all deps must be crates.io versions so if possible we should be looking at pushing releases for all of our repos that are used here.
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zingo_test_vectors = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", branch = "dev" } | ||
| zingo_test_vectors = { git = "https://github.com/zingolabs/infrastructure.git", branch = "dev" } |
| # Zingo-infra | ||
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zingo_test_vectors = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", branch = "dev" } |
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zingo_test_vectors = { git = "https://github.com/zingolabs/infrastructure.git", rev = "20f3c206321825952fdf2d9d84947f5c9d2a1cf4" } | ||
| zcash_local_net = { git = "https://github.com/zingolabs/infrastructure.git", branch = "dev" } | ||
| zingo_test_vectors = { git = "https://github.com/zingolabs/infrastructure.git", branch = "dev" } |
| # Zingo-common | ||
| zingo_common_components = { git = "https://github.com/zingolabs/zingo-common.git", tag = "zingo_common_components_v0.1.0", features = [ "for_test" ]} | ||
| zingo_netutils = { git = "https://github.com/zingolabs/zingo-common.git", rev = "b64dfd6d6a2a597a5456d1cc7b2bc9b649328187" } | ||
| zingo_common_components = { git = "https://github.com/zingolabs/zingo-common.git", branch = "dev", features = [ "for_test" ]} |
| zingo_common_components = { git = "https://github.com/zingolabs/zingo-common.git", tag = "zingo_common_components_v0.1.0", features = [ "for_test" ]} | ||
| zingo_netutils = { git = "https://github.com/zingolabs/zingo-common.git", rev = "b64dfd6d6a2a597a5456d1cc7b2bc9b649328187" } | ||
| zingo_common_components = { git = "https://github.com/zingolabs/zingo-common.git", branch = "dev", features = [ "for_test" ]} | ||
| zingo-netutils = { git = "https://github.com/zingolabs/zingo-common.git", branch = "dev" } |
| prost = { workspace = true } | ||
|
|
||
| [build-dependencies] | ||
| tonic-build = { workspace = true, features = ["prost"] } |
There was a problem hiding this comment.
I think it may be useful to add a comment explaining that "prost" is now part of the tonic-build default-features. So it is clear that if we ever switch off default-features we will need to manually add prost back in.
|
|
||
| [features] | ||
| state_service = [] | ||
| no_tls_use_unencrypted_traffic = ["tonic/tls-roots"] |
There was a problem hiding this comment.
Im a little confused by this, going through the documentation ( https://docs.rs/tonic/0.14.2/tonic/ ) it looks like we do still need to enable tls in our import but it is not clear how this has changed / how it should now be used ( The legacy "TLS" feature has been removed and it looks like it has been split into several TLS backend choices ).
Im unsure if we need to import these here or whether they are specifically for client side implementations. My feeling is we do still need to import here, probably using the "tls-ring" feature flag.
There was a problem hiding this comment.
Hey I think there are a few changes that would be good to make.
I think we should keep to specifying with git revs or better still tagged versions for our imports so we know exactly which version we are importing and need to release to crates.io.
Also Im not certain but it looks like we have removed TLS with these changes currently. I think we will need to use one of the new features added in v0.14.
2 participants
prerequisite for #389
This update has difficult breaking changes in tonic