[top,flash_macro] Extract prim_flash from flash_ctrl#77
Open
matutem wants to merge 1 commit intozerorisc:masterfrom
Open
[top,flash_macro] Extract prim_flash from flash_ctrl#77matutem wants to merge 1 commit intozerorisc:masterfrom
matutem wants to merge 1 commit intozerorisc:masterfrom
Conversation
matutem
force-pushed
the
flash_ctrl_macro
branch
2 times, most recently
from
918396e to
2190fa6
Compare
Contributor
LouisTheLuis
left a comment
LouisTheLuis
left a comment
There was a problem hiding this comment.
LGTM. I only had a single question.
| FlashPartData = 1'b0, | ||
| FlashPartInfo = 1'b1 | ||
| } flash_part_e; | ||
|
|
Contributor
There was a problem hiding this comment.
Why are these moved from flash_ctrl_top_specific_pkg.sv.tpl?
Contributor
Author
There was a problem hiding this comment.
Because it is needed in flash_macro_bank, which is not top-specific, to handle info pages in a special way. Even if there are no info pages the enum makes sense on its own, and the code that handles info pages will never be used.
matutem
force-pushed
the
flash_ctrl_macro
branch
from
2190fa6 to
29a7498
Compare
Please refer to lowRISC/opentitan#27042 for justification and overall approach Addresses lowRISC/opentitan#27042 Signed-off-by: Guillermo Maturana <matute@zerorisc.com>
matutem
force-pushed
the
flash_ctrl_macro
branch
from
29a7498 to
487d082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to lowRISC/opentitan#27042 for justification and overall approach
Addresses lowRISC/opentitan#27042