Skip to content

fix: prevent live folder dismissed tabs from reappearing #12876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
genu wants to merge 1 commit into
base: dev
Choose a base branch
from
+12 −7
Open

fix: prevent live folder dismissed tabs from reappearing #12876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/zen/live-folders/ZenLiveFoldersManager.sys.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,13 +384,18 @@ class nsZenLiveFoldersManager {
animate: !folder.collapsed,
});

// Remove the dismissed items that are no longer in the given list
for (const dismissedItemId of this.dismissedItems) {
if (
dismissedItemId.startsWith(`${liveFolder.id}:`) &&
!itemIds.has(dismissedItemId)
) {
this.dismissedItems.delete(dismissedItemId);
// Remove the dismissed items that are no longer in the given list.
// Only do this when the fetch returned results — an empty list may
// indicate a transient failure (e.g. auth expired, HTML changed)
// and we must not wipe all dismissals in that case.
if (itemIds.size > 0) {
for (const dismissedItemId of this.dismissedItems) {
if (
dismissedItemId.startsWith(`${liveFolder.id}:`) &&
!itemIds.has(dismissedItemId)
) {
this.dismissedItems.delete(dismissedItemId);
}
}
}

Expand Down