fix: prevent live folder dismissed tabs from reappearing#12876
Open
genu wants to merge 1 commit intozen-browser:devfrom
Open
fix: prevent live folder dismissed tabs from reappearing#12876genu wants to merge 1 commit intozen-browser:devfrom
genu wants to merge 1 commit intozen-browser:devfrom
Conversation
dosubot
bot
added
size:S
Slowlife01
reviewed
Mar 22, 2026
genu
force-pushed
the
genu/live-folder-dismissed-tabs
branch
from
79e29d7 to
e983f76
Compare
mr-cheffy
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dismissed live folder tabs (e.g. GitHub PRs) would reappear on startup. Two issues caused this:
Empty fetch wipes dismissals:
onLiveFolderFetchcleaned up dismissed items by removing any not in the current fetch results. If a fetch returned an empty list (auth expired, HTML structure changed), all dismissals were cleared — causing every PR to reappear on the next successful fetch.saveStateearly return: If any single folder's DOM element wasn't found, the entiresaveStatemethod returned early, preventing dismissed items for all folders from being persisted.Fix: guard the dismissed-items cleanup with
itemIds.size > 0, and changereturntocontinueinsaveState.