Skip to content

Add more overrides for rpc bind address and server broadcast address#207

Open
the-glu wants to merge 2 commits intoyugabyte:masterfrom
Orbitalize:fix_overrides
Open

Add more overrides for rpc bind address and server broadcast address#207
the-glu wants to merge 2 commits intoyugabyte:masterfrom
Orbitalize:fix_overrides

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented May 27, 2025

This PR adds optional options to overrides the rpc bind address on master and tserver, and server_broadcast_address on the master (already present on the tserver).

@kv83821-yb
Copy link
Contributor

Hi @the-glu
Can you please add some more context on this ?
Right now, we set the rpc_bind_address as the POD_IP except for Multi-Cluster cases.
The broadcast address is set to pod fqdn. Are you trying to work with any specific MCS setup ?

@the-glu
Copy link
Contributor Author

the-glu commented May 29, 2025

Hello,

Right now, we set the rpc_bind_address as the POD_IP except for Multi-Cluster cases. The broadcast address is set to pod fqdn. Are you trying to work with any specific MCS setup ?

Yes, I'm trying to do a multi cluster setup and yugaybe is using the private_rpc_address even with use_public_ip=never: yugabyte/yugabyte-db#27367

With thoses I'm able to work around the issue by forcing the private_rpc_address to a public one :)

@kv83821-yb
Copy link
Contributor

Which mcs flavor is this ? we can perhaps try to add support for that itself instead of providing direct overrides ? cc: @amannijhawan

Right now we support gke, istio, ocp mcs

@the-glu
Copy link
Contributor Author

the-glu commented Jun 2, 2025

I did try with gke and eks, but I'm not sure it's directly related to the provider

@@ -633,6 +642,10 @@ tserver:
## `use_private_ip: cloud` to the gflags.master and gflags.tserver.
serverBroadcastAddress: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this work in case of multiple masters? Are we mostly setting it to 0.0.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a override in case of someone would like to update it. Without anything set, it will use the server_broadcast_address template, who include the server fqdn

@amannijhawan
Copy link
Contributor

Added a comment, How will this work if we have more than 1 master deployed with the chart ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants