Yugabyte: Working GCP implementation#1190
Conversation
8613d7e to
08c3a7e
Compare
barroco
left a comment
There was a problem hiding this comment.
First pass of comments. May I kindly ask you to provide a list of ports required to be exposed in order to successfully pool two DSS instances?
deploy/infrastructure/dependencies/terraform-commons-dss/variables.gen.tf
Show resolved
Hide resolved
deploy/infrastructure/dependencies/terraform-commons-dss/helm.tf
Outdated
Show resolved
Hide resolved
deploy/infrastructure/dependencies/terraform-google-kubernetes/dns.tf
Outdated
Show resolved
Hide resolved
deploy/infrastructure/dependencies/terraform-google-kubernetes/dns.tf
Outdated
Show resolved
Hide resolved
deploy/infrastructure/dependencies/terraform-google-kubernetes/dns.tf
Outdated
Show resolved
Hide resolved
deploy/infrastructure/dependencies/terraform-commons-dss/helm.tf
Outdated
Show resolved
Hide resolved
| yugabyte = { | ||
| enabled = true | ||
|
|
||
| resource = var.yugabyte_light_resources ? { |
There was a problem hiding this comment.
Let's remove this and address it in another PR if needed. Since there is no autoscalling, this would only change the requested resources without changing the type of nodes provisionned.
There was a problem hiding this comment.
Though, I would expect to see a configuration flag similar to https://github.com/interuss/dss/pull/1190/files#diff-f08dfea212cbd81c9b94266f15255cfd4c4b381b146e7b42c2049c77fbb5560eR24 to indicate the number of nodes.
There was a problem hiding this comment.
It's needed when testing on a small cluster (e.g. by following the default values / README) because the services are requesting a lot of resources, I would suggest to keep it to ease quick / test deployments without having the need of spawning a big cluster.
Not sure how it's related to autoscalling however ?
(Will do add a configuration flag for the number of nodes)
There was a problem hiding this comment.
(Number of nodes support added)
| {{- end }} | ||
|
|
||
| # Tserver nodes Gateways | ||
| {{- range $i, $lb := .Values.loadBalancers.yugabyteTserverNodes }} |
There was a problem hiding this comment.
I don't see the definition of yugabyteTserverNodes. Is it required to expose publicly those ports ?
There was a problem hiding this comment.
Some are needed for inter-tserver communication, and some are needed for the interface / monitoring stuff.
Should we don't want to be able to use the UI, we could limit those, but then the UI will be in a half-working state.
There was a problem hiding this comment.
( yugabyteTserverNodes added )
Co-authored-by: Michael Barroco <michael@orbitalize.com>
This PR introduce changes in the teraform files to support yugabyte in GCP.
It follow #1186 . You probably want to review the last commit only.
It needs the following PRs to make it working even with yugabyte not working correctly with server_broadcast_address ( yugabyte/yugabyte-db#27367 ), we do 'cheat' by injecting into the host file the public host we want, making yugabyte broadcasting the public hostname as private rpc address.
It does the following:
It doesn't have, for now (but the PR is quite big):
It has been tested with two independent GCP k8s clusters that successfully formed a cluster: