Explicitly mark readonly properties

CHANGELOG.md

@@ -6,6 +6,7 @@
   brackets `{{%table}}` (@batyrmastyr)
 - Enh #1145, #1148: Explicitly import classes, functions, and constants in "use" section (@mspirkov)
 - Enh #1148: Add `declare(strict_types=1)` to `Yiisoft\Db\Constant\ColumnInfoSource` (@mspirkov)
+- Enh #1158: Explicitly mark readonly properties (@vjik)
 - Enh #1156: Remove unnecessary files from Composer package (@mspirkov)
 
 ## 2.0.0 December 05, 2025

src/Cache/SchemaCache.php

@@ -42,7 +42,9 @@ final class SchemaCache
      *
      * @link https://www.php-fig.org/psr/psr-16/
      */
-    public function __construct(private CacheInterface $psrCache) {}
+    public function __construct(
+        private readonly CacheInterface $psrCache,
+    ) {}
 
     /**
      * Remove a value with the specified key from cache.

src/Command/AbstractCommand.php

@@ -28,7 +28,7 @@
 /**
  * Represents an SQL statement to execute in a database.
  *
- * It's usually created by calling {@see \Yiisoft\Db\Connection\ConnectionInterface::createCommand()}.
+ * It's usually created by calling {@see ConnectionInterface::createCommand()}.
  *
  * You can get the SQL statement it represents via the {@see getSql()} method.
  *

src/Driver/Pdo/AbstractPdoTransaction.php

@@ -8,6 +8,7 @@
 use Psr\Log\LoggerAwareTrait;
 use Psr\Log\LogLevel;
 use Throwable;
+use Yiisoft\Db\Connection\ConnectionInterface;
 use Yiisoft\Db\Exception\Exception;
 use Yiisoft\Db\Exception\InvalidConfigException;
 use Yiisoft\Db\Exception\NotSupportedException;
@@ -18,7 +19,7 @@
  *
  * A transaction is a set of SQL statements that must either all succeed or all fail.
  *
- * It's usually created by calling {@see \Yiisoft\Db\Connection\AbstractConnectionAbstractConnection::beginTransaction()}.
+ * It's usually created by calling {@see ConnectionInterface::beginTransaction()}.
  *
  * The following code is a typical example of using transactions (note that some DBMS may not support transactions):
  *
@@ -79,7 +80,7 @@
         } else {
             $this->logger?->log(
                 LogLevel::DEBUG,
                 'Transaction not started: nested transaction not supported ' . __METHOD__,
                 ['type' => LogType::TRANSACTION],
             );
 
@@ -180,9 +181,9 @@
             throw new Exception('Failed to set isolation level: transaction was inactive.');
         }
 
         $this->logger?->log(
             LogLevel::DEBUG,
             'Setting transaction isolation level to ' . $this->level . ' ' . __METHOD__,
             ['type' => LogType::TRANSACTION],
         );
         $this->setTransactionIsolationLevel($level);
@@ -212,6 +213,6 @@
      */
     protected function setTransactionIsolationLevel(string $level): void
     {
         $this->db->createCommand("SET TRANSACTION ISOLATION LEVEL $level")->execute();
     }
 }

src/Exception/ConvertException.php

@@ -20,7 +20,10 @@ final class ConvertException
     private const MGS_INTEGRITY_EXCEPTION_2 = 'ORA-00001: unique constraint';
     private const MSG_INTEGRITY_EXCEPTION_3 = 'SQLSTATE[HY';
 
-    public function __construct(private \Exception $e, private string $rawSql) {}
+    public function __construct(
+        private readonly \Exception $e,
+        private readonly string $rawSql,
+    ) {}
 
     /**
      * Converts an exception into a more specific one.

src/Profiler/Context/AbstractContext.php

@@ -14,7 +14,9 @@ abstract class AbstractContext implements ContextInterface
 
     private ?Throwable $exception = null;
 
-    public function __construct(private string $method) {}
+    public function __construct(
+        private readonly string $method,
+    ) {}
 
     public function setException(Throwable $e): static
     {

src/Profiler/Context/CommandContext.php

@@ -11,10 +11,10 @@ final class CommandContext extends AbstractContext
     private const PARAMS = 'params';
 
     public function __construct(
-        private string $method,
-        private string $logContext,
-        private string $sql,
-        private array $params,
+        private readonly string $method,
+        private readonly string $logContext,
+        private readonly string $sql,
+        private readonly array $params,
     ) {
         parent::__construct($this->method);
     }

src/Profiler/ProfilerInterface.php

@@ -7,7 +7,7 @@
 /**
  * Interface-decorator to work with `yiisoft\profiler` or another profiler.
  *
- * @see \Yiisoft\Db\Profiler\ProfilerAwareInterface::setProfiler()
+ * @see ProfilerAwareInterface::setProfiler()
  */
 interface ProfilerInterface
 {

src/Query/QueryExpressionBuilder.php

@@ -21,7 +21,9 @@
  */
 final class QueryExpressionBuilder implements ExpressionBuilderInterface
 {
-    public function __construct(private QueryBuilderInterface $queryBuilder) {}
+    public function __construct(
+        private readonly QueryBuilderInterface $queryBuilder,
+    ) {}
 
     /**
      * @param QueryInterface $expression

src/QueryBuilder/AbstractDQLQueryBuilder.php

@@ -113,7 +113,7 @@ abstract class AbstractDQLQueryBuilder implements DQLQueryBuilderInterface
 
     public function __construct(
         protected QueryBuilderInterface $queryBuilder,
-        private QuoterInterface $quoter,
+        private readonly QuoterInterface $quoter,
     ) {
         $this->expressionBuilders = $this->defaultExpressionBuilders();
         $this->conditionClasses = $this->defaultConditionClasses();

src/QueryBuilder/AbstractQueryBuilder.php

@@ -77,11 +77,11 @@ abstract class AbstractQueryBuilder implements QueryBuilderInterface
     protected array $typeMap = [];
 
     public function __construct(
-        private ConnectionInterface $db,
-        private AbstractDDLQueryBuilder $ddlBuilder,
+        private readonly ConnectionInterface $db,
+        private readonly AbstractDDLQueryBuilder $ddlBuilder,
         private AbstractDMLQueryBuilder $dmlBuilder,
-        private AbstractDQLQueryBuilder $dqlBuilder,
-        private AbstractColumnDefinitionBuilder $columnDefinitionBuilder,
+        private readonly AbstractDQLQueryBuilder $dqlBuilder,
+        private readonly AbstractColumnDefinitionBuilder $columnDefinitionBuilder,
     ) {}
 
     public function addCheck(string $table, string $name, string $expression): string

src/Schema/AbstractSchema.php

@@ -53,7 +53,10 @@ abstract class AbstractSchema implements SchemaInterface
     /** @var (Check[]|DefaultValue[]|ForeignKey[]|Index|Index[]|TableSchemaInterface|null)[][] */
     private array $tableMetadata = [];
 
-    public function __construct(protected ConnectionInterface $db, private SchemaCache $schemaCache) {}
+    public function __construct(
+        protected ConnectionInterface $db,
+        private readonly SchemaCache $schemaCache,
+    ) {}
 
     public function getDefaultSchema(): string
     {

src/Schema/Quoter.php

@@ -38,9 +38,9 @@ class Quoter implements QuoterInterface
 {
     public function __construct(
         /** @psalm-var string[]|string */
-        private array|string $columnQuoteCharacter,
+        private readonly array|string $columnQuoteCharacter,
         /** @psalm-var string[]|string */
-        private array|string $tableQuoteCharacter,
+        private readonly array|string $tableQuoteCharacter,
         private string $tablePrefix = '',
     ) {}