Explicitly mark readonly properties by vjik · Pull Request #1158 · yiisoft/db

vjik · 2026-01-30T13:20:58Z

Q	A
Is bugfix?	❌
New feature?	❌
Breaks BC?	❌
Tests pass?	✔️

codecov · 2026-01-30T13:22:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (e753995) to head (339f90d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1158   +/-   ##
=========================================
  Coverage     98.63%   98.63%           
  Complexity     1654     1654           
=========================================
  Files           120      120           
  Lines          4308     4313    +5     
=========================================
+ Hits           4249     4254    +5     
  Misses           59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Tigrov

What about other properties in other classes? They also can be marked as readonly.

src/Driver/Pdo/AbstractPdoTransaction.php

Tigrov · 2026-01-30T15:29:33Z

src/Driver/Pdo/AbstractPdoTransaction.php

 * A transaction is a set of SQL statements that must either all succeed or all fail.
 *
- * It's usually created by calling {@see \Yiisoft\Db\Connection\AbstractConnectionAbstractConnection::beginTransaction()}.
+ * It's usually created by calling {@see AbstractConnectionAbstractConnection::beginTransaction()}.


Suggested change

* It's usually created by calling {@see AbstractConnectionAbstractConnection::beginTransaction()}.

* It's usually created by calling {@see ConnectionInterface::beginTransaction()}.

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

…y-psr-cache

vjik · 2026-02-01T14:59:31Z

What about other properties in other classes? They also can be marked as readonly.

Done

Tigrov · 2026-02-02T04:10:50Z

src/QueryBuilder/AbstractDQLQueryBuilder.php

@@ -113,7 +113,7 @@ abstract class AbstractDQLQueryBuilder implements DQLQueryBuilderInterface

    public function __construct(
        protected QueryBuilderInterface $queryBuilder,


Suggested change

protected QueryBuilderInterface $queryBuilder,

protected readonly QueryBuilderInterface $queryBuilder,

This breaks BC.

Tigrov · 2026-02-02T04:13:48Z

src/QueryBuilder/AbstractQueryBuilder.php

-        private AbstractDDLQueryBuilder $ddlBuilder,
+        private readonly ConnectionInterface $db,
+        private readonly AbstractDDLQueryBuilder $ddlBuilder,
        private AbstractDMLQueryBuilder $dmlBuilder,


Suggested change

private AbstractDMLQueryBuilder $dmlBuilder,

private readonly AbstractDMLQueryBuilder $dmlBuilder,

This property is not readonly. See withTypecasting() method.

Tigrov · 2026-02-02T04:16:10Z

src/Schema/AbstractSchema.php


-    public function __construct(protected ConnectionInterface $db, private SchemaCache $schemaCache) {}
+    public function __construct(
+        protected ConnectionInterface $db,


Suggested change

protected ConnectionInterface $db,

protected readonly ConnectionInterface $db,

This breaks BC.

vjik and others added 2 commits January 30, 2026 16:20

Mark $psrCache property in SchemaCache as readonly

5b37e4a

Apply PHP CS Fixer and Rector changes (CI)

248cfcd

vjik requested a review from a team January 30, 2026 13:24

vjik added the status:code review The pull request needs review. label Jan 30, 2026

Tigrov reviewed Jan 30, 2026

View reviewed changes

vjik and others added 6 commits January 30, 2026 23:08

Update src/Driver/Pdo/AbstractPdoTransaction.php

2187c7c

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Apply PHP CS Fixer and Rector changes (CI)

4514dd8

Merge branch 'master' into readonly-psr-cache

bff97d1

Explicitly mark readonly properties

890f980

Merge remote-tracking branch 'origin/readonly-psr-cache' into readonl…

55a84e0

…y-psr-cache

fix

d470ee0

vjik changed the title ~~Mark $psrCache property in SchemaCache as readonly~~ Explicitly mark readonly properties Feb 1, 2026

fix

339f90d

vjik requested a review from Tigrov February 1, 2026 14:59

Tigrov reviewed Feb 2, 2026

View reviewed changes

Tigrov approved these changes Feb 2, 2026

View reviewed changes

vjik merged commit 1f38570 into master Feb 2, 2026
80 of 81 checks passed

vjik deleted the readonly-psr-cache branch February 2, 2026 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Explicitly mark readonly properties#1158

Explicitly mark readonly properties#1158
vjik merged 9 commits intomasterfrom
readonly-psr-cache

vjik commented Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

Tigrov left a comment

Uh oh!

Uh oh!

Tigrov Jan 30, 2026

Uh oh!

vjik Feb 1, 2026

Uh oh!

vjik commented Feb 1, 2026

Uh oh!

Tigrov Feb 2, 2026

Uh oh!

vjik Feb 2, 2026

Uh oh!

Tigrov Feb 2, 2026

Uh oh!

vjik Feb 2, 2026

Uh oh!

Tigrov Feb 2, 2026

Uh oh!

vjik Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	* It's usually created by calling {@see AbstractConnectionAbstractConnection::beginTransaction()}.
	* It's usually created by calling {@see ConnectionInterface::beginTransaction()}.

		@@ -113,7 +113,7 @@ abstract class AbstractDQLQueryBuilder implements DQLQueryBuilderInterface

		public function __construct(
		protected QueryBuilderInterface $queryBuilder,

	protected QueryBuilderInterface $queryBuilder,
	protected readonly QueryBuilderInterface $queryBuilder,

	private AbstractDMLQueryBuilder $dmlBuilder,
	private readonly AbstractDMLQueryBuilder $dmlBuilder,

	protected ConnectionInterface $db,
	protected readonly ConnectionInterface $db,

Uh oh!

Conversation

vjik commented Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Tigrov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vjik commented Feb 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 30, 2026 •

edited

Loading