Skip to content

flush and seek in _download_source_file() #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RichardBruskiewich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

flush and seek in _download_source_file() #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions s3_tar/s3_tar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,12 @@ def _download_source_file(self, key):
"""
source_key_io = io.BytesIO()
self.s3.download_fileobj(self.source_bucket, key, source_key_io)

# Maybe necessary to flush and seek to the EOF,
# see https://github.com/boto/boto3/issues/1304
source_key_io.flush()
source_key_io.seek(0, 2)

return source_key_io

def _download_source_metadata(self, key):
Expand Down