flush and seek in _download_source_file()#11
Open
RichardBruskiewich wants to merge 1 commit intoxtream1101:masterfrom
Open
flush and seek in _download_source_file()#11RichardBruskiewich wants to merge 1 commit intoxtream1101:masterfrom
RichardBruskiewich wants to merge 1 commit intoxtream1101:masterfrom
Conversation
Observed truncation of large files inserted into archive. It seems necessary to flush and seek to the EOF of source_key_io to avoid this, see boto/boto3#1304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed truncation of large files inserted into archive. It seems necessary to flush and seek to the EOF of
source_key_ioto avoid this, see boto/boto3#1304. As this Boto issue indicates, multipart downloads (with threaded transfers?) make the filetell()position somewhat indeterminate at times. Flushing the file and seeking to the end, appears to repair this problem. Otherwise, TarInfo in_save_bytes_to_tarwill be given the wrong size for its files.