Skip to content

fix: fix is_underused fn #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k82cn merged 4 commits into from
Jan 23, 2026
Merged

fix: fix is_underused fn #324

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26bc70f
fix: fix is_underused fn
k82cn Jan 23, 2026
021ad94
Update session_manager/src/scheduler/plugins/mod.rs
k82cn Jan 23, 2026
ada8e0b
Update session_manager/src/scheduler/plugins/mod.rs
k82cn Jan 23, 2026
caf7ec6
Update session_manager/src/scheduler/plugins/mod.rs
k82cn Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 10 additions & 28 deletions session_manager/src/scheduler/plugins/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl PluginManager {

Ok(plugins
.values()
.all(|plugin| plugin.is_underused(ssn).unwrap_or(false)))
.any(|plugin| plugin.is_underused(ssn).unwrap_or(false)))
}

pub fn is_preemptible(&self, ssn: &SessionInfoPtr) -> Result<bool, FlameError> {
Expand All @@ -110,15 +110,9 @@ impl PluginManager {
) -> Result<bool, FlameError> {
let plugins = lock_ptr!(self.plugins)?;

for plugin in plugins.values() {
if let Some(available) = plugin.is_available(exec, ssn) {
if !available {
return Ok(false);
}
}
}

Ok(true)
Ok(plugins
.values()
.all(|plugin| plugin.is_available(exec, ssn).unwrap_or(true)))
}

pub fn is_allocatable(
Expand All @@ -128,29 +122,17 @@ impl PluginManager {
) -> Result<bool, FlameError> {
let plugins = lock_ptr!(self.plugins)?;

for plugin in plugins.values() {
if let Some(allocatable) = plugin.is_allocatable(node, ssn) {
if !allocatable {
return Ok(false);
}
}
}

Ok(true)
Ok(plugins
.values()
.all(|plugin| plugin.is_allocatable(node, ssn).unwrap_or(true)))
}

pub fn is_reclaimable(&self, exec: &ExecutorInfoPtr) -> Result<bool, FlameError> {
let plugins = lock_ptr!(self.plugins)?;

for plugin in plugins.values() {
if let Some(reclaimable) = plugin.is_reclaimable(exec) {
if !reclaimable {
return Ok(false);
}
}
}

Ok(true)
Ok(plugins
.values()
.all(|plugin| plugin.is_reclaimable(exec).unwrap_or(true)))
}

pub fn on_create_executor(
Expand Down
Loading