fix: fix is_underused fn

[k82cn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @k82cn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a logical bug within the plugin manager's is_underused function, ensuring that a session is correctly identified as underused if at least one plugin indicates it. In addition to this fix, several other boolean-returning functions related to plugin checks, such as is_available, is_allocatable, and is_reclaimable, have been refactored to use more concise and idiomatic Rust iterator methods, enhancing the codebase's readability and maintainability.

Highlights

• Logical Correction in is_underused: The is_underused function's logic has been corrected from requiring all plugins to report a session as underused to requiring any plugin to do so, aligning with the intended behavior for identifying underutilized sessions.
• Code Refactoring for Plugin Checks: The is_available, is_allocatable, and is_reclaimable functions have been refactored to utilize Rust's Iterator::all method. This change improves code conciseness and readability by replacing explicit for loops with a more idiomatic functional approach, without altering the existing logical behavior of these checks.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes the logic in is_underused by switching from all() to any(). However, it also introduces critical bugs in is_available, is_allocatable, and is_reclaimable during refactoring. The new implementations incorrectly handle None return values from plugins, changing permissive logic to restrictive, which could disrupt scheduling. I've provided suggestions to correct this behavior.