Open
Conversation
added 5 commits
November 9, 2018 08:24
…e even when they wouldn't ordinarily appear
|
Would love to see this PR make it in to a release (assuming this is all still in active development)... |
|
Could you please follow up .. |
|
Is there any plan to merge this PR into the current version? |
|
Will this be merged before the world ends? |
Author
|
I'm the author of this PR (but not the maintainer of this package). For what it's worth, I'm actually removing our forked version of react-js-pagination from the app that uses it. Given that, I don't really have the motivation to maintain the fork. @vayser, if you have any interest in merging this patch at some point soon, let me know. If not, I am going to close this PR in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to include the first and/or last page when they wouldn't appear normally in the range, along with an ellipsis (...). The text of the ellipsis element can be customized, and the element will use the normal classes for items and disabled links that the rest of the Pagination component will be using.