-
Notifications
You must be signed in to change notification settings - Fork 57
Target gutenberg monorepo branch #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Solution adapted from https://stackoverflow.com/a/58976218
|
Pushed a In case a
It's checking to reverse the patch first, and if fails it means that the patch is not applied so, going ahead with applying it. |
|
@hypest The patch is printing Edit: Pushed the fix |
3fac01a to
ef092c1
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Description
The goal of this PR is to target the gutenberg monorepo branch. With this change
gutenbergwill receive more responsibility and gutenberg-mobile becomes a "customized experience" of the core RN editor. The idea is to have tests at both places. On gutenberg, integrated as part of the default CI and here as part of our usual contributions and releases.Gutenberg PR: WordPress/gutenberg#21332
WordPress-Android PR: wordpress-mobile/WordPress-Android#11956
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#14188
Testing instructions
Check that all the following commands are working correctly. When running the "enhanced" gutenberg mobile you should see "Welcome to gutenberg for WP apps" as the post title while it should just display "Welcome to gutenberg" for the core version.
npm installnpm startnpm run start:resetnpm run core androidnpm run core iosnpm run genstringsnpm run bundlenpm run testnpm run core testnpm run test:e2e:android:localnpm run test:e2e:ios:localnpm run core test:e2e:android:localnpm run core test:e2e:ios:localnpm run wpandroidCode review
The "Hide deleted files" option on github should help with the review:

PR submission checklist:
RELEASE-NOTES.txtif necessary.