Fix potential crash after "uuid" package upgrade in Gutenberg #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@marecar3 is this the same solution you did in the RN 0.62 branch? |
Contributor
Yes, that's correct @SergioEstevao. |
Contributor
Author
|
Should be resolved via #2172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes potential crash after
uuidpackage upgrade in Gutenberg:WordPress/gutenberg#21258
The new
uuidversion usescrypto.getRandomValueswhich is not supported in React Native:https://github.com/uuidjs/uuid/tree/f6ce4bffc2b10d92f3164e76e877e5cdb7942474#getrandomvalues-not-supported
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.