Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Add Paystack as fallback gateway#7025

Merged
joshuatf merged 3 commits intomainfrom
add/6855-paystack
May 25, 2021
Merged

Add Paystack as fallback gateway#7025
joshuatf merged 3 commits intomainfrom
add/6855-paystack

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented May 19, 2021 •
edited
Loading

Fixes (part of) #6855

Adds Paystack as a fallback gateway when remote recommended gateways aren't fetched.

Screenshots

Screen Shot 2021-05-19 at 4 51 40 PM

Detailed test instructions:

  1. Check out this branch of the Paystack plugin and install/activate. Try: Add quick setup settings for gateway recommendations tubiz/woo-paystack#63
  2. Visit the task list and the Paystack payment task.
  3. Check that the required fields are shown.
  4. If the new data store is merged (Add a new store to interact with WC Payments REST APIs #6918) and hooked up (pending), check that the currency is updated to ZAR and testmode is turned off after updated.

@joshuatf joshuatf requested a review from a team May 19, 2021 20:54
@joshuatf joshuatf self-assigned this May 19, 2021
@joshuatf joshuatf mentioned this pull request May 19, 2021
Closed
Base automatically changed from add/6855 to main May 19, 2021 22:49
@joshuatf joshuatf force-pushed the add/6855-paystack branch from 03b6456 to 9c6ee62 Compare May 19, 2021 22:54
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for a team May 24, 2021 22:47
@joelclimbsthings
Copy link
Contributor

joelclimbsthings commented May 24, 2021

Hey @joshuatf , having trouble getting the paystack method to show up. I've installed the paystack branch, tried setting myself to the US and South africa, and disabled the remote payment tester. Before I spend more time on this, just wanted to see if I might be missing something?

psealock
psealock approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @joshuatf, this is testing well for me and code looks good too. I left an unrelated comment on excluding CBD stores for Stripe.

src/Features/RemotePaymentMethods/DefaultPaymentGateways.php
'type' => 'option',
'option_name' => 'woocommerce_onboarding_profile',
'value' => 'cbd-other-hemp-derived-products',
'operation' => '!contains',
Copy link
Contributor

@psealock psealock May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this check in a few places and it doesn't work. The reason is because industry isn't a simple array

Screen Shot 2021-05-25 at 11 50 03 AM

This is why transformers were added in #6948. See the readme of that PR for the correct implementation. I know several Remote Inbox Notifications are guilty of this as well.

Copy link
Contributor Author

@joshuatf joshuatf May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Updated this in f42004e

@psealock psealock added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed status: needs review labels May 24, 2021
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for joelclimbsthings May 25, 2021 00:12
@psealock psealock mentioned this pull request May 25, 2021
Merged
@joshuatf joshuatf force-pushed the add/6855-paystack branch from f42004e to 2a3718b Compare May 25, 2021 14:55
@joshuatf
Copy link
Contributor Author

joshuatf commented May 25, 2021

Thanks for taking the time to review @joelclimbsthings and @psealock!

@joelclimbsthings If you had the remote tester installed, you may also need to delete the remote transient. Just a heads up that this will be true of all remote payment related tasks.

@joshuatf joshuatf force-pushed the add/6855-paystack branch from 2a3718b to 63a0f97 Compare May 25, 2021 15:20
@joshuatf joshuatf merged commit 2479979 into main May 25, 2021
@joshuatf joshuatf deleted the add/6855-paystack branch May 25, 2021 15:41
ObliviousHarmony pushed a commit to woocommerce/woocommerce that referenced this pull request Mar 18, 2022
@joshuatf
Add Paystack as fallback gateway (woocommerce/woocommerce-admin#7025)
90710e1 
* Add paystack to fallback payment gateways

* Add changelog entry

* Fix CBD rules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joelclimbsthings joelclimbsthings Awaiting requested review from joelclimbsthings

1 more reviewer

@psealock psealock psealock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joshuatf joshuatf

Labels

needs: author feedback The issue/PR needs a response from any of the parties involved in the issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshuatf @joelclimbsthings @psealock