This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Conversation
psealock
approved these changes
May 25, 2021
Contributor
psealock
left a comment
psealock
left a comment
There was a problem hiding this comment.
This is testing well, just a comment about the CBD check.
Also, is this just for India?
| 'type' => 'option', | ||
| 'option_name' => 'woocommerce_onboarding_profile', | ||
| 'value' => 'cbd-other-hemp-derived-products', | ||
| 'operation' => '!contains', |
psealock
added
needs: author feedback
Contributor
Author
The pre-existing logic required PayPal to show when not in India and for the store to not be in the CBD industry. |
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…#7044) * Add PayPal as default fallback gateway * Filter out fields that aren't found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (part of) #6855
Note: The PayPal gateway will require some refactoring for the connection URL and setup keys now showing in the REST response. This PR is simply about getting the gateway to show up in the recommendations list.
Screenshots
Detailed test instructions: