Skip to content

[b/328439250] Remove NULL expectations from boolean columns #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanclary wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[b/328439250] Remove NULL expectations from boolean columns #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tdvt/tdvt/exprtests/standard/expected.setup.calcs_data.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
<schema>
<column>[cast_calcs.postgres91].[TEMP(Test)(3428507074)(0)]</column>
</schema>
<tuple>
<value>%null%</value>
</tuple>
Copy link

@jswett77 jswett77 Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the datasets, is this removing an expected column value or row value?

Copy link
Author

@tanclary tanclary Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's removing a single cell from the expected results. you can see in the above tag the name of the column you're removing a row from.

Copy link

@Anthrino Anthrino Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info @tanclary, sorry missed checking information you added to the bug.
LGTM for the change.

Copy link
Author

@tanclary tanclary Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries thanks for looking y'all 👍

<tuple>
<value>false</value>
</tuple>
Expand All @@ -20,9 +17,6 @@
<schema>
<column>[cast_calcs.postgres91].[TEMP(Test)(1935567978)(0)]</column>
</schema>
<tuple>
<value>%null%</value>
</tuple>
<tuple>
<value>false</value>
</tuple>
Expand All @@ -49,9 +43,6 @@
<schema>
<column>[cast_calcs.postgres91].[TEMP(Test)(1288552116)(0)]</column>
</schema>
<tuple>
<value>%null%</value>
</tuple>
<tuple>
<value>false</value>
</tuple>
Expand Down
3 changes: 0 additions & 3 deletions tdvt/tdvt/exprtests/standard/expected.setup.cast.str.8.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@
<schema>
<column>[cast_calcs.memsql].[TEMP(Test)(3200082645)(0)]</column>
</schema>
<tuple>
<value>%null%</value>
</tuple>
<tuple>
<value>&quot;0&quot;</value>
</tuple>
Expand Down