[b/328439250] Remove NULL expectations from boolean columns#2
[b/328439250] Remove NULL expectations from boolean columns#2tanclary wants to merge 1 commit intownob:masterfrom
Conversation
Dimensions of type YESNO in LookML will never return NULL, so when we select a boolean column in the SQL Interface, we should never expect NULL.
| </schema> | ||
| <tuple> | ||
| <value>%null%</value> | ||
| </tuple> |
There was a problem hiding this comment.
Not familiar with the datasets, is this removing an expected column value or row value?
There was a problem hiding this comment.
It's removing a single cell from the expected results. you can see in the above tag the name of the column you're removing a row from.
There was a problem hiding this comment.
Thanks for the info @tanclary, sorry missed checking information you added to the bug.
LGTM for the change.
There was a problem hiding this comment.
No worries thanks for looking y'all 👍
Yes it's in the commit message and on the bug, tl:dr YESNO fields don't allow return NULL. |
3 participants
No description provided.