Upgrade to Storybook 6.5

[lucaswerkmeister]

No description provided.

[github-actions]

https://3e326027e271231f5168d69ccc948adfa0513cc5--wmde-wikit.netlify.app

[lucaswerkmeister]

Huh, it now works under Node 16 (including in CI), but not under Node 14 (e.g. in Fresh). That seems unfortunate. (Originally, we required Node 16 to have npm >6, so Fresh with Node 14 but npm 7 should’ve been fine.)

[lucaswerkmeister]

Merged in the latest changes (especially #598); now it seems to work under Node 14 again.

[lucaswerkmeister]

I don’t understand the CI error – npx lerna bootstrap --ci works locally, both under Node 14 and 16…

[micgro42]

I don’t understand the CI error – npx lerna bootstrap --ci works locally, both under Node 14 and 16…

Mh, it says

lerna ERR! npm ci exited 1 in '@wmde/wikit-docs'

and

npm ERR! Missing: typescript@4.7.3 from lock file

I had this error earlier too, and it went away when updating the dependencies in the docs/ directory

Also, I think I was only really able to reproduce the error when manually deleting the node_modules directory (but maybe that's spurioous, npm ci is supposed to do that)

[micgro42]

Wait.

⌂4.21 [michael:~/workspace/wikit/docs]└3 next-storybook-6.5 ± npm ls typescript
@wmde/wikit-docs@3.0.0-alpha.4 /home/michael/workspace/wikit/docs
└─┬ @wmde/wikit-vue-components@3.0.0-alpha.4 -> ./../vue-components
  ├─┬ @storybook/builder-webpack5@6.5.6
  │ └─┬ fork-ts-checker-webpack-plugin@6.5.2
  │   └── typescript@4.5.5 deduped
  ├─┬ @storybook/vue3@6.5.6
  │ └─┬ ts-loader@8.4.0
  │   └── typescript@4.5.5 deduped
  ├─┬ @typescript-eslint/eslint-plugin@5.17.0
  │ └─┬ tsutils@3.21.0
  │   └── typescript@4.5.5 deduped
  ├─┬ @vue/cli-plugin-typescript@5.0.4
  │ └── typescript@4.5.5 deduped
  ├─┬ @vue/eslint-config-typescript@11.0.0
  │ └── typescript@4.5.5 deduped
  ├─┬ @vue/vue3-jest@27.0.0-alpha.4
  │ └── typescript@4.5.5 deduped
  ├─┬ ts-jest@27.1.4
  │ └── typescript@4.5.5 deduped
  ├─┬ ts-loader@9.3.0
  │ └── typescript@4.5.5 deduped
  └── typescript@4.5.5

[micgro42]

Though it might be worth to run an npm upgrade and go to storybook 6.5.9 just for good measure

[lucaswerkmeister]

Hm, I sometimes get errors like this when messing with the packages:

I have no name!@211a2f0e173a:/wikit$ npm -C docs/ upgrade
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @wmde/wikit-docs@3.0.0-alpha.4
npm ERR! Found: react@16.14.0
npm ERR! node_modules/react
npm ERR!   dev react@"^16.14.0" from the root project
npm ERR!   peer react@"^16.8.0 || ^17.0.0 || ^18.0.0" from @storybook/builder-webpack5@6.5.9
npm ERR!   node_modules/@storybook/builder-webpack5
npm ERR!     dev @storybook/builder-webpack5@"^6.5.9" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.2.0" from react-dom@18.2.0
npm ERR! node_modules/react-dom
npm ERR!   peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0" from @storybook/builder-webpack5@6.5.9
npm ERR!   node_modules/@storybook/builder-webpack5
npm ERR!     dev @storybook/builder-webpack5@"^6.5.9" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /cache/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /cache/_logs/2022-06-17T13_54_59_164Z-debug.log

So far, my solution to that was to npm -C docs/ i react-dom@16 to make it install, then manually remove the dependency from docs/package.json, then run npm -C docs/ i one more time to refresh the lockfile. But I guess that might be related to the problems here…