This repository was archived by the owner on May 1, 2025. It is now read-only.
Migrate Link component to the next branch #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM; why does CI complain that |
Collaborator
Author
|
No idea, but we might as well have a PR to update the dependencies on the |
Member
|
Hm, I didn’t merge #594 yet because of the Node 16 requirement :/ |
micgro42
added a commit
that referenced
this pull request
Jun 16, 2022
This is originally done in order to work around a CI failure in #597 that showed up as follows: ``` npm ERR! code EUSAGE npm ERR! npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing. npm ERR! npm ERR! Invalid: lock file's acorn@7.4.1 does not satisfy acorn@8.7.1 npm ERR! Missing: acorn@7.4.1 from lock file npm ERR! Missing: acorn@7.4.1 from lock file npm ERR! Missing: typescript@4.7.3 from lock file npm ERR! Missing: acorn@7.4.1 from lock file ``` The original cause is still unclear, but it was possible to reproduce that error by forcing `lerna bootstrap` to always perform a CI installation, even locally. Fixing that issue resulted somehow in test failures like: ``` FAIL tests/unit/components/Lookup.spec.ts ● Test suite failed to run No element indexed by 27 at ArraySet_at [as at] (node_modules/@vue/vue3-jest/node_modules/source-map/lib/array-set.js:92:9) at Array.map (<anonymous>) at mapLines (node_modules/@vue/vue3-jest/lib/map-lines.js:12:18) at processScript (node_modules/@vue/vue3-jest/lib/process.js:47:16) at Object.module.exports [as process] (node_modules/@vue/vue3-jest/lib/process.js:162:24) ``` which were solved by another `npm update` in `vue-components/`. Co-authored-by: Lucas Werkmeister <lucas.werkmeister@wikimedia.de>
micgro42
force-pushed
the
next-LinkComponent
branch
from
e436a35 to
460a4b5
Compare
This fixes the issue that "Link" is apparently a reserved word in HTML. Renaming the filename seems unnecessary though.
lucaswerkmeister
approved these changes
Jun 17, 2022
micgro42
changed the title
micgro42
added a commit
that referenced
this pull request
Jun 17, 2022
This was forgotten in #597 We really should have some test for this :/.
micgro42
added a commit
that referenced
this pull request
Jun 20, 2022
This was forgotten in #597 We really should have some test for this :/.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the help-link to the spelling variant input
Bug: T298146