Skip to content

wording #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pythcoiner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wording #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gui/src/installer/step/bitcoind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ impl InternalBitcoindConfig {
);
} else if !prop.is_empty() {
return Err(InternalBitcoindConfigError::UnexpectedSection(
"General section should be empty".to_string(),
"bitcoin.conf general section should be empty".to_string(),
Copy link
Copy Markdown
Collaborator

@jp1ac4 jp1ac4 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be slightly better to mention the bitcoin.conf file in the ReadingFile error as returned by the from_file method below. You could also include the path to the file in this error variant's message. Then the "General section should be empty" message would be added at the end as additional info. For this, I think you'd need to wrap the error from Self::from_ini(&conf_ini) inside the ReadingFile error.

Copy link
Copy Markdown
Collaborator

@jp1ac4 jp1ac4 Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option could be to mention the bitcoin.conf file in the UnexpectedSection error, which currently says "Unexpected section in file", and this message would also be shown for any other unexpected sections apart from the general section.

));
}
}
Expand Down