Open
Conversation
jp1ac4
reviewed
Mar 4, 2024
| } else if !prop.is_empty() { | ||
| return Err(InternalBitcoindConfigError::UnexpectedSection( | ||
| "General section should be empty".to_string(), | ||
| "bitcoin.conf general section should be empty".to_string(), |
Collaborator
There was a problem hiding this comment.
It might be slightly better to mention the bitcoin.conf file in the ReadingFile error as returned by the from_file method below. You could also include the path to the file in this error variant's message. Then the "General section should be empty" message would be added at the end as additional info. For this, I think you'd need to wrap the error from Self::from_ini(&conf_ini) inside the ReadingFile error.
Collaborator
There was a problem hiding this comment.
Another option could be to mention the bitcoin.conf file in the UnexpectedSection error, which currently says "Unexpected section in file", and this message would also be shown for any other unexpected sections apart from the general section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as pointed by #989 the error message was not explicit