Implement GetVersion command for all devices#24
Merged
edouardparis merged 7 commits intowizardsardine:mainfrom Apr 10, 2026
Merged
Implement GetVersion command for all devices#24edouardparis merged 7 commits intowizardsardine:mainfrom
edouardparis merged 7 commits intowizardsardine:mainfrom
Conversation
When the Coldcard emulator isn't running there was an IO error that prevented other devices from being enumerated.
Perhaps not the best way to handle errors, but for now it's much more useful during development.
Collaborator
Author
|
@edouardparis thanks for reviewing! Pushed the fixes. |
Lots of work inspired by async-hwi and LedgerHQ/app-bitcoin-new
Coldcold returns a giant newline delimited string, so we will parse that out and get the invalid semver (can contain letters) and the device model.
edouardparis
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a lot of async-hwi's implementation for getting device version.
Once this is merged, I will put up a fix for #23. I needed this first so that I
can query the configured network from the devices and then we can match it up
with what the CLI is expecting.
I tried to make each commit clean so that it's easy to review commit-by-commit.