Skip to content

Altered order of operations to ensure modules are seeded before plugins #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeTowers merged 1 commit into from
Jan 24, 2022
Merged

Altered order of operations to ensure modules are seeded before plugins #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions modules/system/classes/UpdateManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,6 @@ public function update()
}
}

/*
* Update plugins
*/
foreach ($plugins as $code => $plugin) {
$this->updatePlugin($code);
}

Parameter::set('system::update.count', 0);
CacheHelper::clear();

/*
* Seed modules
*/
Expand All @@ -184,6 +174,16 @@ public function update()
}
}

/*
* Update plugins
*/
foreach ($plugins as $code => $plugin) {
$this->updatePlugin($code);
}

Parameter::set('system::update.count', 0);
CacheHelper::clear();

// Set replacement warning messages
foreach ($this->pluginManager->getReplacementMap() as $alias => $plugin) {
if ($this->pluginManager->getActiveReplacementMap($alias)) {
Expand Down