Skip to content

Altered order of operations to ensure modules are seeded before plugins #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukeTowers merged 1 commit into from
Jan 24, 2022
Merged

Altered order of operations to ensure modules are seeded before plugins #419

LukeTowers merged 1 commit into from
Jan 24, 2022

Conversation

@jaxwilko
Copy link
Member

@jaxwilko jaxwilko commented Jan 24, 2022 •
edited by gitpod-io bot
Loading

If a plugin has seeds that interacts with module tables, this can cause issues as currently the module seeders will be ran after the plugin seeders.

This PR is a simple change that alters the UpdateManager to run module seeders before updating plugins.

@bennothommo bennothommo added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Jan 24, 2022
@LukeTowers LukeTowers added this to the v1.1.8 milestone Jan 24, 2022
@LukeTowers LukeTowers merged commit 927719f into develop Jan 24, 2022
@LukeTowers LukeTowers deleted the fix/module-seeders branch January 24, 2022 14:32
LukeTowers added a commit that referenced this pull request Jan 26, 2022
@LukeTowers
Merge branch 'develop' of github.com:wintercms/winter into develop
ed775a3 
* 'develop' of github.com:wintercms/winter:
  Sort assets alphabetically in the CMS Theme Editor (#420)
  VSCode recommended extensions (#417)
  Altered order of operations to ensure modules are seeded before plugins (#419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennothommo bennothommo bennothommo approved these changes

Assignees

No one assigned

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.1.8

Development

Successfully merging this pull request may close these issues.

4 participants

@jaxwilko @bennothommo @LukeTowers