Skip to content

Use FormBuilder to build backend form dropdown #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeTowers merged 4 commits into from
Dec 10, 2025
+24 −29
Merged

Use FormBuilder to build backend form dropdown #1427

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66fdae5
Use FormBuilder::select() method to build backend form dropdown
mjauvin Dec 6, 2025
2a3cea6
fix indent and define $emptyOption
mjauvin Dec 6, 2025
a478885
fix inverted logic
mjauvin Dec 6, 2025
6fcf1ba
Apply suggestion from @LukeTowers
LukeTowers Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 24 additions & 29 deletions modules/backend/widgets/form/partials/_field_dropdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?php
$fieldOptions = $field->options();
$useSearch = $field->getConfig('showSearch', true);
$emptyOption = $field->getConfig('emptyOption', $field->placeholder);
$allowCustom = $field->getConfig('allowCustom', false);
?>

<!-- Dropdown -->
Expand All @@ -11,30 +8,28 @@
<?= (isset($fieldOptions[$field->value])) ? e(trans($fieldOptions[$field->value])) : '' ?>
</div>
<input type="hidden" name="<?= $field->getName() ?>" value="<?= $field->value ?>">
<?php else: ?>
<select
id="<?= $field->getId() ?>"
name="<?= $field->getName() ?>"
class="form-control custom-select <?= $useSearch ? '' : 'select-no-search' ?> <?= $allowCustom ? 'select-modifiable' : '' ?>"
<?= $field->getAttributes() ?>
<?= $field->placeholder ? 'data-placeholder="'.e(trans($field->placeholder)).'"' : '' ?>
>
<?php if ($emptyOption): ?>
<option value=""><?= e(trans($emptyOption)) ?></option>
<?php endif ?>
<?php foreach ($fieldOptions as $value => $option): ?>
<?php
if (!is_array($option)) {
$option = [$option];
}
?>
<option
<?= $field->isSelected($value) ? 'selected="selected"' : '' ?>
<?php if (isset($option[1])): ?>
data-<?= strpos($option[1], '.') ? 'image' : 'icon' ?>="<?= $option[1] ?>"
<?php endif ?>
value="<?= e($value) ?>"
><?= e(trans($option[0])) ?></option>
<?php endforeach ?>
</select>
<?php else:
$emptyOption = $field->getConfig('emptyOption', $field->placeholder);
$options = $field->getAttributes(htmlBuild:false);
$options['id'] = $field->getId();
$options['class'] = 'form-control custom-select';
if ($field->getConfig('showSearch', true) === false) {
$options['class'] .= ' select-no-search';
}
if ($field->getConfig('allowCustom', false)) {
$options['class'] .= ' select-modifiable';
}
if ($emptyOption) {
$options['emptyOption'] = e(trans($emptyOption));
}
if ($field->placeholder) {
$options['data-placeholder'] = e(trans($field->placeholder));
}
?>
<?= Form::select(
name: $field->getName(),
list: $fieldOptions,
selected: $field->value,
options: $options
) ?>
<?php endif ?>
Loading