Skip to content

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Dec 6, 2025

Depends on wintercms/storm#222
Related to wintercms/docs#253

This also adds support for optGroup in dropdown through the FormBuilder.

Summary by CodeRabbit

  • Refactor
    • Consolidated dropdown rendering into a single, consistent path for improved reliability and easier maintenance.
    • Preserves user-facing behaviors: placeholder, optional search, custom-option entry, empty-option handling, and preview/read-only display.
    • Error and accessibility handling unified to reduce rendering inconsistencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@mjauvin mjauvin added this to the 1.2.10 milestone Dec 6, 2025
@mjauvin mjauvin requested a review from LukeTowers December 6, 2025 15:09
@mjauvin mjauvin self-assigned this Dec 6, 2025
@mjauvin mjauvin added the enhancement PRs that implement a new feature or substantial change label Dec 6, 2025
coderabbitai[bot]

This comment was marked as resolved.

@LukeTowers
Copy link
Member

@coderabbitai review this

@coderabbitai

This comment was marked as resolved.

@wintercms wintercms deleted a comment from coderabbitai bot Dec 10, 2025
@wintercms wintercms deleted a comment from coderabbitai bot Dec 10, 2025
@LukeTowers LukeTowers merged commit 8906269 into develop Dec 10, 2025
14 checks passed
@LukeTowers LukeTowers deleted the backend-form-dropdown-use-formbuilder branch December 10, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that implement a new feature or substantial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants