Skip to content

Fix https-only behaviour #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tripsolutions wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix https-only behaviour #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyramid_jwt/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def set_jwt_cookie_authentication_policy(
json_encoder=None,
audience=None,
cookie_name=None,
https_only=True,
https_only=None,
reissue_time=None,
cookie_path=None,
):
Expand Down
3 changes: 2 additions & 1 deletion src/pyramid_jwt/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import jwt
from pyramid.renderers import JSON
from pyramid.settings import asbool
from webob.cookies import CookieProfile
from zope.interface import implementer
from pyramid.authentication import CallbackAuthenticationPolicy
Expand Down Expand Up @@ -187,7 +188,7 @@ def __init__(
audience,
)

self.https_only = https_only
self.https_only = asbool(https_only)
self.cookie_name = cookie_name or "Authorization"
self.max_age = self.expiration and self.expiration.total_seconds()

Expand Down