Open
Conversation
- read from ini-file unless overridden from parameter - convert from string to bool, required for ini-file setting
tripsolutions
force-pushed
the
fix-https-only
branch
from
f10edf6 to
a4a333d
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because set_jwt_authentication_policy's https_only parameter had a default value set to True the ini-file value was never being picked up. You would need to explicitly pass https_only=None to set_jwt_cookie_authentication_policy for the ini-file value to be considered. The ini-file value would also always be a string.