Skip to content

Dragon icon preview rotation bug #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tcm390 wants to merge 1 commit into from
Closed

Dragon icon preview rotation bug #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions object-spriter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {fitCameraToBoundingBox} from './util.js';

const localVector = new THREE.Vector3();
const localVector2 = new THREE.Vector3();
// const localVector3 = new THREE.Vector3();
const localVector3 = new THREE.Vector3();
// const localVector2D = new THREE.Vector2();
// const localVector2D2 = new THREE.Vector2();
const localVector4D = new THREE.Vector4();
Expand Down Expand Up @@ -101,19 +101,24 @@ const createObjectSpriteInternal = (app, {

// set up side camera
const angle = (i / numFrames) * Math.PI * 2;
sideCamera.position.copy(app.position)
const physicsObjects = app.getPhysicsObjects();
if (physicsObjects.length > 0) {
const physicsObject = physicsObjects[0];
const {physicsMesh} = physicsObject;
sideCamera.position.copy(physicsMesh.geometry.boundingBox.getCenter(localVector3))
.add(
localVector.set(Math.cos(angle), 0, Math.sin(angle))
.applyQuaternion(app.quaternion)
.multiplyScalar(2)
);

const physicsObjects = app.getPhysicsObjects();
if (physicsObjects.length > 0) {
const physicsObject = physicsObjects[0];
const {physicsMesh} = physicsObject;
fitCameraToBoundingBox(sideCamera, physicsMesh.geometry.boundingBox, 1.2);
} else {
sideCamera.position.copy(app.position)
.add(
localVector.set(Math.cos(angle), 0, Math.sin(angle))
.applyQuaternion(app.quaternion)
.multiplyScalar(2)
);
sideCamera.quaternion.setFromRotationMatrix(
localMatrix.lookAt(
sideCamera.position,
Expand Down