Closed
Conversation
|
Looks good to me. Dragon preview is working fine. |
avaer
approved these changes
Aug 20, 2022
Contributor
avaer
left a comment
avaer
left a comment
There was a problem hiding this comment.
Code looks good, I think we can merge it upstream.
Contributor
|
Also this should not be related to the dragon -- it should be a fix for all apps. |
Contributor
|
Merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
fitCameraToBoundingBoxfunction, we set the direction according to the camera position and bounding box center. So I think we should also set the camera position based on the bounding box center in object-spriter.jsapp/util.js
Line 720 in 0f2afad
related:
#3501
related PR (No previews for bow bug)
webaverse/bow#11
Result:
Webaverse.-.Google.Chrome.2022-08-15.21-03-35.mp4
Webaverse.-.Google.Chrome.2022-08-15.21-04-28.mp4
Webaverse.-.Google.Chrome.2022-08-15.21-05-17.mp4