Open
Conversation
magenta404
commented
Feb 2, 2024
magenta404
commented
Feb 2, 2024
magenta404
force-pushed
the
burstify-queries
branch
from
90abea4 to
0847b55
Compare
magenta404
force-pushed
the
burstify-queries
branch
2 times, most recently
from
e7f88f1 to
d56698e
Compare
Contributor
|
Do these changes make it so the Query for water heights can be done in a Job? |
Takes work from #1059 and retargets it to master branch. Changes made from that PR: - Add scripting symbol to opt-in to Burst queries - Keep current API as default to avoid breaking change - Formatting - Excluded some superfluous changes Co-authored-by: Dale Eidd <dale@eidd.name>
Also add helpers to pass the equivalent of null for non-burst API.
magenta404
force-pushed
the
burstify-queries
branch
from
d56698e to
b41ed59
Compare
Collaborator
Author
|
Only Burst compiled. I have updated the branch to 4.20.1 if you would like to see if there is an improvement and give feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes work from and replaces #1059
Based off master instead of experimental as few things changed to adopt this mainstream. Requires an opt-in via scripting symbol "CREST_BURST_QUERY" to avoid a breaking change.