burst queries and calculating velocities#1059
Closed
ecuzzillo wants to merge 1 commit intowave-harmonic:experimentalfrom
Closed
burst queries and calculating velocities#1059ecuzzillo wants to merge 1 commit intowave-harmonic:experimentalfrom
ecuzzillo wants to merge 1 commit intowave-harmonic:experimentalfrom
Conversation
…native collections for that purpose
magenta404
added a commit
that referenced
this pull request
Feb 2, 2024
Takes work from #1059 and retargets it to master branch. Changes made from that PR: - Add scripting symbol to opt-in to Burst queries - Keep current API as default to avoid breaking change - Formatting - Excluded some superfluous changes Co-authored-by: Dale Eidd <dale@eidd.name>
Collaborator
|
Thank you for the PR. In the end decided to push this out to mainstream so had to change the base to the master branch (required copying work over). Closing this in favour of #1143 |
magenta404
added a commit
that referenced
this pull request
Apr 5, 2024
Takes work from #1059 and retargets it to master branch. Changes made from that PR: - Add scripting symbol to opt-in to Burst queries - Keep current API as default to avoid breaking change - Formatting - Excluded some superfluous changes Co-authored-by: Dale Eidd <dale@eidd.name>
magenta404
added a commit
that referenced
this pull request
May 19, 2024
Takes work from #1059 and retargets it to master branch. Changes made from that PR: - Add scripting symbol to opt-in to Burst queries - Keep current API as default to avoid breaking change - Formatting - Excluded some superfluous changes Co-authored-by: Dale Eidd <dale@eidd.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And, move many things to NativeCollections for that purpose.
In our game, in areas with several water objects, this change made Query() calls disappear from the profiler, where before they had taken 2-5ms/frame.
This only bursts the things that showed up for our particular usage, but the changes here likely enable bursting many more things for other use cases.