Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Feature/detect UUID#445

Open
EstebanDalelR wants to merge 3 commits intodevfrom
feature/detectUUID
Open

Feature/detect UUID#445
EstebanDalelR wants to merge 3 commits intodevfrom
feature/detectUUID

Conversation

@EstebanDalelR
Copy link
Member

Description

Adds comments for UUID intances

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC
  • Test

Notes

Acceptance

@vercel
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 3:32pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Feb 1, 2024

Watermelon AI Summary

This Pull Request introduces a new feature where it implements the capability to detect and handle UUIDs within the system, including updating the user interface to reflect this new functionality.

GitHub PRs

watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How do I test? With what PR that introduces this pattern can I test?

  2. Please expand on the argument that this is a code smell. Is it because it leaks access to the DB? Are only certain kinds of IDs a vulnerability (eg: sequential ones that can give the attacker a way to brute force)? Are non-obvious IDs something that can be exposed to the world?

@EstebanDalelR
Copy link
Member Author

  1. How do I test? With what PR that introduces this pattern can I test?

    1. Please expand on the argument that this is a code smell. Is it because it leaks access to the DB? Are only certain kinds of IDs a vulnerability (eg: sequential ones that can give the attacker a way to brute force)? Are non-obvious IDs something that can be exposed to the world?
  1. Introduce an UUID in a PR
  2. There should not be UUIDs in the code, having them hard coded is a smell. It's fine if you put them somewhere visible, but definitely should not commit them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants