Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Feature/detect jwt#444

Open
EstebanDalelR wants to merge 5 commits intodevfrom
feature/detect-JWT
Open

Feature/detect jwt#444
EstebanDalelR wants to merge 5 commits intodevfrom
feature/detect-JWT

Conversation

@EstebanDalelR
Copy link
Member

Description

Adds comments if we find JWT

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC
  • Test

Notes

Acceptance

@vercel
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 3:31pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Feb 1, 2024

Watermelon AI Summary

This Pull Request introduces a new feature that automatically identifies JSON Web Tokens (JWTs) within the code and adds relevant comments for better tracking or alerting. It also includes a cleanup task where outdated code related to left-out comments detection was removed and necessary updates and bug fixes were applied to ensure integration with the development branch.

GitHub PRs

Slack Threads

Notion Pages

watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of this code smell.

However, I created PR #446 to test and it didn't detect the raw JWT

@EstebanDalelR
Copy link
Member Author

I like the idea of this code smell.

However, I created PR #446 to test and it didn't detect the raw JWT

I understand, did it find anything? Cuz there is an error preventing all code smells still to be tested

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants