Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Chore/extract PR grading#333

Merged
EstebanDalelR merged 8 commits intodevfrom
chore/extract-badge-grading
Oct 23, 2023
Merged

Chore/extract PR grading#333
EstebanDalelR merged 8 commits intodevfrom
chore/extract-badge-grading

Conversation

@EstebanDalelR
Copy link
Member

Description

This makes console log detection and PR grading to when our bot comments.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Several improvements come from this, such as launching a different function.
We depend on the text being correct, which in most cases is true.
In the future we can use this to respond to user queries when another user asks.

Acceptance

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Oct 19, 2023

WatermelonAI Summary

The commits in this Pull Request are focused on improving the business logic of the PR grading process. They include extracting PR labeling, fixing missing parameters, removing unnecessary logging, reordering the labeling process, adding a response with tracking information, simplifying the code structure, and adding editing comments to triggers. These changes aim to enhance the functionality of the bot's PR grading feature, ensuring that console log detection and grading occur when the bot comments. The PR description also mentions that these improvements can potentially be used to respond to user queries in the future.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Slack Threads deactivated by EstebanDalelR

Notion Pages

Linear Tickets deactivated by EstebanDalelR
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:57pm

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with a new payload that syncrhonyzes PR #331 and it works like a charm.

Would just like to get an answer to the question about the order of the functions before approving.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants