Watermelon using app token (team tool)#326
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WatermelonAI SummaryThe 25 commits in the Pull Request are primarily focused on improving the business logic related to team match and user information retrieval. Changes include adding more logging, fixing text clarity, improving parameter handling, simplifying code, and removing unnecessary code. Additionally, the use of the app token instead of the user token is implemented for retrieving information. Overall, these changes aim to enhance the process of team matching and user data management within the application. GitHub PRsClick here to login to Jira Notion PagesLinear Tickets deactivated by EstebanDalelR |
EstebanDalelR
changed the title
EstebanDalelR
changed the title
utils/actions/getAllServices.ts
Outdated
| return { error: error.message }; | ||
| } | ||
| const [github, jira, confluence, slack, notion, linear, asana] = | ||
| const [github, teamGitHub, jira, confluence, slack, notion, linear, asana] = |
There was a problem hiding this comment.
Nice idiomatic var name
There was a problem hiding this comment.
Testing notes:
- Tested with the previously successful payload on #324 and it works
- Tested on #328 after deleting estebanvargas94 (username associated to the estebanvargasgarcia1994@gmail.com email) with the previously successful payload that I used to create the PR. Got a new comment asking me to login
app/api/actions/github/route.ts
Outdated
| issue_number: number, | ||
| repo, | ||
| body: "[Please login to Watermelon to see the results](https://app.watermelontools.com/)", | ||
| body: "[Please login to GitHub in Watermelon to see the results](https://app.watermelontools.com/)", |
There was a problem hiding this comment.
Fix to the text, there is no way to find a user without them logging in.
@baristaGeek
baristaGeek
left a comment
baristaGeek
left a comment
There was a problem hiding this comment.
Approving understanding the technical restrictions that we have.
This is working properly now |
If this improves cool, but it's not a priority |
|
I think we're very close! I didn't get "user not registered" as the last time and actually got a successful response. Is the only thing left to do actually executing the commenting -> detecting console logs -> labeling the PR flow? 
|
baristaGeek
left a comment
baristaGeek
left a comment
There was a problem hiding this comment.
Approving because it's working better than the current version of #334 (I recognize there are merge conflicts). The hard part works 🎉 🎉
We just have to fix placeholder={Teammate@${teamName.toLowerCase()}.com} which is something minor
Weird, this line hasn't ever been touched. |
|
Anyway I opened #342 with that. |
You're right this is broken in prod. Let's fix it. For now let's merge this |
2 participants
Description
Uses the app token instead of the user token to get info
Type of change
Notes
Acceptance