Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Feature/trinary pr labeling#322

Merged
baristaGeek merged 4 commits intodevfrom
feature/trinary-pr-labeling
Oct 11, 2023
Merged

Feature/trinary pr labeling#322
baristaGeek merged 4 commits intodevfrom
feature/trinary-pr-labeling

Conversation

@baristaGeek
Copy link
Collaborator

Description

Because we want to provide more feedback while maintaining strictness about what's a PR pre-approval and what's not, we're adding a trinary PR labeling system to our GitHub app.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Possibly due to the recent permission changes, the github params validation wasn't working so I removed that piece of logic in labelPullRequest.ts

Acceptance

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 10:52pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Oct 10, 2023

WatermelonAI Summary

The 4 commits in this PR are focused on improving the labeling system in our GitHub app. Commit 1 removes GitHub parameter validation due to recent permission changes. Commit 2 removes production console logs. Commit 3 adds logic to remove outdated PR labels. Commit 4 changes the emoji used for the "take a deeper dive" label. These changes indicate that the business logic of our labeling system is being refined and optimized, with a focus on providing better feedback and maintaining strictness in PR pre-approval.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Notion Pages deactivated by baristaGeek
Linear Tickets deactivated by baristaGeek
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link
Member

@EstebanDalelR EstebanDalelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did open #323 to make it more readable.

@baristaGeek baristaGeek merged commit cca1d2c into dev Oct 11, 2023
@baristaGeek baristaGeek mentioned this pull request Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants