Skip to content

Replace Create by OpenFile #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waltervargas merged 1 commit into from
Jul 11, 2023
Merged

Replace Create by OpenFile #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gobdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func (db Gobdb[T]) List() []T {
// during the process, the method returns the error with details about what
// went wrong.
func (db *Gobdb[T]) Add(d ...T) error {
file, err := os.Create(db.path)
file, err := os.OpenFile(db.path, os.O_APPEND|os.O_WRONLY, os.ModeAppend)
if err != nil {
return fmt.Errorf("unable to open file: %w", err)
}
Expand Down
2 changes: 1 addition & 1 deletion gobdb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestAdd(t *testing.T) {
want := []string{"barbara", "victor", "walter"}
err = db.Add(want...)
if err != nil {
t.Errorf("unable to add data %v: %s", want, err)
t.Fatalf("unable to add data %v: %s", want, err)
}
got := db.List()
if !cmp.Equal(want, got) {
Expand Down