Skip to content

Replace Create by OpenFile#5

Merged
waltervargas merged 1 commit intowaltervargas:mainfrom
thiagonache:main
Jul 11, 2023
Merged

Replace Create by OpenFile#5
waltervargas merged 1 commit intowaltervargas:mainfrom
thiagonache:main

Conversation

@thiagonache
Copy link
Copy Markdown
Contributor

Create truncates the file if it already exists. We should use OpenFile with append mode. Also fixes the test to stop if it cannot write data to the database

… with append mode. Also fixes the test to stop if it cannot write data to the database
@waltervargas waltervargas merged commit ac48ae9 into waltervargas:main Jul 11, 2023
@waltervargas
Copy link
Copy Markdown
Owner

thanks @thiagonache !

@waltervargas
Copy link
Copy Markdown
Owner

Create truncates the file if it already exists. We should use OpenFile with append mode. Also fixes the test to stop if it cannot write data to the database

Its actually what we want here, since Add is persisting, I merged it before thinking about it (my bad, coming back from a flu), and I also have changes locally that needs to be pushed.

I'll will push them on a next PR and then you will see a new Sync method.

@thiagonache
Copy link
Copy Markdown
Contributor Author

thiagonache commented Jul 11, 2023 via email

@waltervargas
Copy link
Copy Markdown
Owner

Does Add re-add all the data? I missed that sorrySent from my iPhoneOn 11 Jul 2023, at 11:02, Walter Vargas @.> wrote: Create truncates the file if it already exists. We should use OpenFile with append mode. Also fixes the test to stop if it cannot write data to the database Its actually what we want here, since Add is persisting, I merged it before thinking about it (my bad, coming back from a flu), and I also have changes locally that needs to be pushed. I'll will push them on a next PR and then you will see a new Sync method. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

the PR: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants