Replace Create by OpenFile#5
Conversation
… with append mode. Also fixes the test to stop if it cannot write data to the database
|
thanks @thiagonache ! |
Its actually what we want here, since Add is persisting, I merged it before thinking about it (my bad, coming back from a flu), and I also have changes locally that needs to be pushed. I'll will push them on a next PR and then you will see a new Sync method. |
|
Does Add re-add all the data? I missed that sorrySent from my iPhoneOn 11 Jul 2023, at 11:02, Walter Vargas ***@***.***> wrote:
Create truncates the file if it already exists. We should use OpenFile with append mode. Also fixes the test to stop if it cannot write data to the database
Its actually what we want here, since Add is persisting, I merged it before thinking about it (my bad, coming back from a flu), and I also have changes locally that needs to be pushed.
I'll will push them on a next PR and then you will see a new Sync method.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
the PR: #6 |
Create truncates the file if it already exists. We should use OpenFile with append mode. Also fixes the test to stop if it cannot write data to the database