Skip to content

Remove use of realms #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoscaceres merged 1 commit into from
Nov 29, 2022
Merged

Remove use of realms #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 14 additions & 24 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,8 @@ <h2>
"powerful feature">name</dfn>, which is a string literal (e.g., "geolocation").
</p>
<p>
The user agent is responsible for tracking which <a>powerful features</a> each [=global
object/realm=] has the user's [=permission=] to use via the [=environment settings
object=].
The user agent tracks which <a>powerful features</a> the user has [=permission=] to use
via the [=environment settings object=].
Comment on lines +320 to +321
Copy link
Copy Markdown
Member

@jyasskin jyasskin Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies that the user is forbidden from using some features, but it's really the user who grants permission for the environment settings objects (ESOs) to use the features.

I think this change is replacing Realm-scope with origin scope? So it might say:

Suggested change
The user agent tracks which <a>powerful features</a> the user has [=permission=] to use
via the [=environment settings object=].
The user agent tracks which <a>powerful features</a> each [=origin=] has the user's [=permission=] to use....

I don't remember anymore why it's "via the ESO", and an origin tends to have multiple ESOs, so "the" isn't really the right article once things have transitioned to origins.

Copy link
Copy Markdown
Member Author

@marcoscaceres marcoscaceres Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I think we might need to reframe all this as part of #390 (as that will govern how permissions are associated with origins).

</p>
<section>
<h3>
Expand Down Expand Up @@ -439,7 +438,7 @@ <h2>
</p>
<p class="note" data-cite="mediacapture-streams ECMAScript">
For example, {{MediaDevices/getUserMedia()}} needs to determine <em>which</em> cameras
the user has granted [=ECMAScript/the current realm record=] permission to access.
the user has granted permission to access.
</p>
<p>
If a {{DOMString}} |name| names one of these features, then |name|'s <dfn data-dfn-for=
Expand Down Expand Up @@ -665,8 +664,8 @@ <h3 id="requesting-more-permission">
</li>
<li>If the user gives [=express permission=] to use the powerful feature, return
{{PermissionState/"granted"}}; otherwise return {{PermissionState/"denied"}}. The user's
interaction may provide <a>new information about the user's intent</a> for this [=global
object/realm=] and other [=global object/realms=] with the <a>same origin</a>.
interaction may provide <a>new information about the user's intent</a> for the
[=origin=].
<p class="note">
This is intentionally vague about the details of the permission UI and how the user
agent infers user intent. User agents should be able to explore lots of UI within
Expand Down Expand Up @@ -714,9 +713,7 @@ <h3>
</ol>
</li>
<li>If the user chose one or more options, return them; otherwise return
{{PermissionState/"denied"}}. If the user's interaction indicates they intend this choice
to apply to other realms, then treat this this as <a>new information about the user's
intent</a> for other [=global object/realms=] with the <a>same origin</a>.
{{PermissionState/"denied"}}.
<p class="note">
This is intentionally vague about the details of the permission UI and how the user
agent infers user intent. User agents should be able to explore lots of UI within
Expand All @@ -736,15 +733,13 @@ <h3 id="reacting-to-revocation">
Reacting to users revoking permission
</h3>
<p>
When the user agent learns that the user no longer intends to grant permission for a
[=global object/realm=] to use a <a>feature</a>, <dfn>react to the user revoking
permission</dfn> by running these steps:
When the user agent learns that the user no longer intends to grant permission to use a
<a>feature</a>, <dfn>react to the user revoking permission</dfn> by running these steps:
</p>
<ol class="algorithm">
<li>
<a>Queue a task</a> on the Realm's [=Realm/settings object=]'s [=environment settings
object/responsible event loop=] to run that feature's [=powerful feature/permission
revocation algorithm=].
<a>Queue a global task</a> on the [=user interaction task source=] to run that
feature's [=powerful feature/permission revocation algorithm=].
</li>
</ol>
</section>
Expand Down Expand Up @@ -1024,7 +1019,6 @@ <h2 id="automation">
dictionary PermissionSetParameters {
required PermissionDescriptor descriptor;
required PermissionState state;
boolean oneRealm = false;
};
</pre>
<section>
Expand Down Expand Up @@ -1080,12 +1074,9 @@ <h3 id="set-permission-command">
</li>
<li>Let |settings| be the [=current settings object=].
</li>
<li>If |parameters|.{{PermissionSetParameters/oneRealm}} is true, let |targets| be a <a>
list</a> whose sole member is |settings|.
</li>
<li>Otherwise, let |targets| be a <a>list</a> containing all <a>environment settings
objects</a> whose [=environment settings object/origin=] is the <a data-lt="same origin">
same</a> as the [=environment settings object/origin=] of |settings|.
<li>Let |targets| be a <a>list</a> containing all <a>environment settings objects</a>
whose [=environment settings object/origin=] is the <a data-lt="same origin">same</a> as
the [=environment settings object/origin=] of |settings|.
</li>
<li>Let |tasks| be an empty <a>list</a>.
</li>
Expand Down Expand Up @@ -1143,8 +1134,7 @@ <h2 id="privacy-considerations">
</p>
<p>
A user agent SHOULD provide a means for the user to review, update, and reset the
[=permission=] [=permission/state=] of [=powerful features=] associated with a realm or
origin.
[=permission=] [=permission/state=] of [=powerful features=] associated with an [=origin=].
</p>
</section>
<section id="security-considerations">
Expand Down