Merged
Conversation
marcoscaceres
force-pushed
the
consume
branch
from
8c3f3c4 to
92db397
Compare
Member
Author
|
Sent a PR to remove it from WPT web-platform-tests/wpt#37152 ... it might need to go through the RFC process, but not sure yet. |
marcoscaceres
force-pushed
the
consume
branch
from
92db397 to
80fca1a
Compare
miketaylr
approved these changes
Nov 28, 2022
jyasskin
reviewed
Nov 28, 2022
Comment on lines
+320
to
+321
| The user agent tracks which <a>powerful features</a> the user has [=permission=] to use | ||
| via the [=environment settings object=]. |
Member
There was a problem hiding this comment.
This implies that the user is forbidden from using some features, but it's really the user who grants permission for the environment settings objects (ESOs) to use the features.
I think this change is replacing Realm-scope with origin scope? So it might say:
Suggested change
| The user agent tracks which <a>powerful features</a> the user has [=permission=] to use | |
| via the [=environment settings object=]. | |
| The user agent tracks which <a>powerful features</a> each [=origin=] has the user's [=permission=] to use.... |
I don't remember anymore why it's "via the ESO", and an origin tends to have multiple ESOs, so "the" isn't really the right article once things have transitioned to origins.
Member
Author
There was a problem hiding this comment.
right, I think we might need to reframe all this as part of #390 (as that will govern how permissions are associated with origins).
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 6, 2022
This concept was removed in w3c/permissions#397 and the shared WPT pieces were already removed in web-platform-tests/wpt#37152. Chrome never supported it outside of ignoring the parameter. Bug: 977612 Change-Id: I69b5838dea5d25ddf9345689bf220d8a9a1bf602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079214 Auto-Submit: Johann Hofmann <johannhof@chromium.org> Commit-Queue: Johann Hofmann <johannhof@chromium.org> Reviewed-by: Vladimir Nechaev <nechaev@chromium.org> Cr-Commit-Position: refs/heads/main@{#1079726}
T3-M4
pushed a commit
to bayandin/chromedriver
that referenced
this pull request
Dec 7, 2022
This concept was removed in w3c/permissions#397 and the shared WPT pieces were already removed in web-platform-tests/wpt#37152. Chrome never supported it outside of ignoring the parameter. Bug: 977612 Change-Id: I69b5838dea5d25ddf9345689bf220d8a9a1bf602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079214 Auto-Submit: Johann Hofmann <johannhof@chromium.org> Commit-Queue: Johann Hofmann <johannhof@chromium.org> Reviewed-by: Vladimir Nechaev <nechaev@chromium.org> Cr-Commit-Position: refs/heads/main@{#1079726}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #387
The following tasks have been completed:
Implementation commitment:
Preview | Diff