Skip to content

Feature/visible label and accessible name do not match #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmourac-vtex merged 5 commits into from
Feb 9, 2026
Merged

Feature/visible label and accessible name do not match #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b33b8d
feat: accessible label and visible name as the same
antoniovsbasilio Jan 5, 2026
35de4d5
feat: update changelog
antoniovsbasilio Jan 5, 2026
766da87
Add fix for aria-label in CHANGELOG
iago1501 Feb 9, 2026
3e1419f
Merge branch 'master' into feature/visible-label-and-accessible-name-…
vmourac-vtex Feb 9, 2026
998f793
fix lint errors
vmourac-vtex Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Fixed

- Change aria-label in shelf to be the same as product name (visible label)

## [2.91.1] - 2026-01-07

### Added
Expand Down
8 changes: 2 additions & 6 deletions react/ProductSummaryCustom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,7 @@
to: href,
onClick: autocompleteSummary ? actionOnClick : undefined,
onClickCapture: autocompleteSummary ? undefined : actionOnClick,
'aria-label': `View product details for ${
product?.productName || 'product'
}`,
'aria-label': `${product?.productName || 'product'}`,
}
: {
page: 'store.product',
Expand All @@ -184,13 +182,11 @@
query,
onClick: autocompleteSummary ? actionOnClick : undefined,
onClickCapture: autocompleteSummary ? undefined : actionOnClick,
'aria-label': `View product details for ${
product?.productName || 'product'
}`,
'aria-label': `${product?.productName || 'product'}`,
}

const eventParameters =
(product.advertisement as any)?.eventParameters ??

Check warning on line 189 in react/ProductSummaryCustom.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
product.advertisement?.adId

const showSponsoredBadge = shouldShowSponsoredBadge(
Expand Down
Loading