Skip to content

Feature/visible label and accessible name do not match#416

Merged
vmourac-vtex merged 5 commits intovtex-apps:masterfrom
antoniovsbasilio:feature/visible-label-and-accessible-name-do-not-match
Feb 9, 2026
Merged

Feature/visible label and accessible name do not match#416
vmourac-vtex merged 5 commits intovtex-apps:masterfrom
antoniovsbasilio:feature/visible-label-and-accessible-name-do-not-match

Conversation

@antoniovsbasilio
Copy link
Copy Markdown
Contributor

What problem is this solving?

This PR fixes an accessibility mismatch between the visible text labels and the accessible names (aria-label) within the Product Summary components.

According to https://my2.siteimprove.com/ audits, interactive elements must have an accessible name that contains the visible text. Currently, some elements provide different strings for assistive technologies than what is displayed on the screen, which:

Confuses speech-input users who try to activate a button by its visible name.

Creates a disconnected experience for screen reader users.

It states:

The accessible name of any interactive element should contain its visible text label.

Using two different names for a single page element can create a confusing user experience for assistive technology users.

For example, speech-input users may have difficulty activating a control if the label displayed on-screen does not match its accessible name.

Screenshots or example usage:

Screenshot 2026-01-05 at 11 19 34

@antoniovsbasilio antoniovsbasilio requested review from a team as code owners January 5, 2026 14:23
@antoniovsbasilio antoniovsbasilio requested review from leo-prange-vtex, vmourac-vtex and vsseixaso and removed request for a team January 5, 2026 14:23
@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd bot commented Jan 5, 2026

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link
Copy Markdown

vtex-io-docs-bot bot commented Jan 5, 2026

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Updated CHANGELOG to include a fix for aria-label consistency.
Copy link
Copy Markdown
Contributor

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the semantic message from changelog, nice catch

@vmourac-vtex vmourac-vtex merged commit 0b1a710 into vtex-apps:master Feb 9, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants