Skip to content

Add deployment guides for Qwen3 and Qwen3 FP8 models on SageMaker#191

Open
shrimpnoodles wants to merge 3 commits intovllm-project:mainfrom
shrimpnoodles:qwen3-update
Open

Add deployment guides for Qwen3 and Qwen3 FP8 models on SageMaker#191
shrimpnoodles wants to merge 3 commits intovllm-project:mainfrom
shrimpnoodles:qwen3-update

Conversation

@shrimpnoodles
Copy link

No description provided.

Signed-off-by: Hani Cierlak <hannahcierlak@gmail.com>
Signed-off-by: Hani Cierlak <hannahcierlak@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shrimpnoodles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive documentation for deploying Qwen3 large language models on AWS SageMaker. It provides two distinct guides: one for the full-precision Qwen3 model and another for its FP8 quantized counterpart. The guides detail the necessary AWS infrastructure, Docker image preparation with vLLM, specific environment configurations for optimal performance, and practical steps for deployment, inference, and resource management.

Highlights

  • New Deployment Guides: Introduced two comprehensive guides for deploying Qwen3 and Qwen3 FP8 models on AWS SageMaker, leveraging vLLM and Docker for efficient inference.
  • Hardware and Instance Recommendations: Detailed hardware requirements, including specific GPU architectures (Ada Lovelace, Hopper, Ampere) for FP8 models and general GPU compute capabilities for full-precision models. Recommended AWS instance types like ml.g6.48xlarge with justifications for GPU count based on Qwen3's GQA architecture.
  • vLLM Configuration: Provided specific vLLM environment variable configurations for each model variant, including tensor parallel size, maximum model length, GPU memory utilization, and enabling expert parallelism for FP8 models.
  • End-to-End Deployment Workflow: Outlined a complete deployment strategy covering IAM permissions, Python dependencies, Docker image setup, ECR integration, SageMaker model deployment, example inference requests, and resource cleanup.
  • Troubleshooting Section: Included dedicated troubleshooting tips for common issues such as memory errors, tensor parallel errors, and container startup timeouts, with actionable solutions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two comprehensive and well-structured deployment guides for Qwen3 and Qwen3 FP8 models on AWS SageMaker. The guides are a valuable addition, covering everything from hardware requirements to deployment and troubleshooting. I've included a few minor suggestions to address some inconsistencies in the Docker setup instructions and troubleshooting sections, which will help improve the clarity and accuracy for users. Overall, this is an excellent contribution.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Hani Cierlak <hannahcierlak@gmail.com>
@shrimpnoodles
Copy link
Author

shrimpnoodles commented Jan 9, 2026

Comments reviewed, ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant